feat(#428): auto-reindex MCP search after handover clone#429
Conversation
atlas-apex
left a comment
There was a problem hiding this comment.
Code Review: PR #429
Commit: 4053b1dcfbf696f88b729ca3b96cd9453806c9a3
Summary
Updates the /handover SKILL.md to trigger an MCP reindex after a successful workspace clone, so search_code returns results immediately for the new project instead of waiting for the next session start. The reindex is best-effort (skips silently if MCP isn't available).
Checklist Results
- ✅ Architecture & Design: Pass — skill documentation change only, no code; the reindex call follows the established MCP tool invocation pattern
- ✅ Code Quality: Pass — clear step numbering, best-effort semantics documented, idempotent operation
- ✅ Testing: Pass — N/A for a SKILL.md documentation change (testing instructions in PR body are manual verification)
- ✅ Security: Pass — no secrets, no new inputs, MCP reindex is a read-only indexing operation
- ✅ Performance: Pass — reindex is async and best-effort; doesn't block the handover flow
- ✅ PR Description & Glossary: Pass — glossary defines MCP reindex
- ⚠ Summary Bullet Narrative: Pass
- ✅ Technical Decisions (AgDR): N/A — no new libraries or patterns; extends existing MCP integration documented in the search-first enforcement PR
Issues Found
None.
Suggestions
None — this is a clean, minimal SKILL.md change that adds a single well-scoped step to the handover flow.
Verdict
APPROVED (posted as comment — cannot approve own PR)
🤖 Reviewed by Rex (Code Reviewer Agent)
📌 Reviewed commit: 4053b1dcfbf696f88b729ca3b96cd9453806c9a3
Add step 4 to the handover clone flow: trigger mcp__apexyard-search__reindex(scope=project, project=<name>) after a successful git clone. Best-effort — skips silently if the MCP server isn't running. Without this, search_code returns empty results for newly-cloned projects until the next session start (when index_on_session_start fires). The reindex takes ~2-5s for a single project. Refs #428 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
4053b1d to
791c9fc
Compare
atlas-apex
left a comment
There was a problem hiding this comment.
Code Review: PR #429 (post-rebase re-review)
Commit: 791c9fc414ef6cc5385ea6d5bb3be53d12e89291
Summary
Re-review after rebase onto dev to pick up the site-counts fix from #427. The change itself is unchanged from the prior approval — a 9-line addition to .claude/skills/handover/SKILL.md that triggers mcp__apexyard-search__reindex(scope=project, project=<name>) after a successful workspace clone, with best-effort semantics (silent skip if the MCP server isn't running).
Checklist Results
- Architecture & Design: Pass — skill-level behaviour change, no architectural impact
- Code Quality: Pass — markdown-only diff, clear prose
- Testing: Pass — testing steps in PR body cover both code paths (clone vs no-clone)
- Security: Pass — no auth/secrets/user-data touched; reindex is local-only
- Performance: Pass — best-effort, non-blocking, runs once per handover
- PR Description & Glossary: Pass — Summary + Testing + Glossary all present; bullets are narrative ("Auto-reindex on clone — /handover now triggers… so search_code returns results immediately"); links Refs #428
- Summary Bullet Narrative: Pass — both bullets answer what + why
- Technical Decisions (AgDR):N/A — uses existing MCP tool, no new dependency or pattern choice
- Adopter Handbooks: N/A — diff is markdown only, no language handbooks fire; architecture + general handbooks have no applicable findings
Issues Found
None.
Verdict
APPROVED (recorded as comment — agent cannot self-approve via GitHub UI)
The rebase preserves the semantic change exactly. Best-effort UX (silent skip if MCP unavailable) is the right call — it keeps /handover runnable on machines without the search server.
Reviewed by Rex (Code Reviewer Agent)
Reviewed commit: 791c9fc
…429) Add step 4 to the handover clone flow: trigger mcp__apexyard-search__reindex(scope=project, project=<name>) after a successful git clone. Best-effort — skips silently if the MCP server isn't running. Without this, search_code returns empty results for newly-cloned projects until the next session start (when index_on_session_start fires). The reindex takes ~2-5s for a single project. Refs #428 Co-authored-by: me2resh <ahmed.abdelaliem@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
/handovernow triggersmcp__apexyard-search__reindex(scope=project, project=<name>)after a successful workspace clone, sosearch_codereturns results immediately instead of waiting for next session start.Testing
/handoverwith a clone → verifysearch_codereturns results for the new project/handoverwithout clone → no reindex attemptGlossary
Refs #428
🤖 Generated with Claude Code