feat(#32): /setup first-run bootstrap + deprecate /onboard + update CLAUDE.md#33
Merged
Conversation
…s table Introduces the first-run bootstrap experience for new ApexStack forks. Three exchanges instead of eight questions: "describe your stack", "here are the defaults", "accept or customize?" Design split: - /setup = framework-level (once per fork, writes onboarding.yaml) - /handover = project-level (once per project, writes project-config) - /onboard = deprecated, redirects to /setup or /handover ## /setup skill .claude/skills/setup/SKILL.md — the "describe, propose, confirm" flow. Reads the user's natural-language stack description, maps to onboarding.yaml fields, proposes a complete config, asks for one yes/no confirmation. Stages but does not commit — lets the user review the diff first. Idempotent (re-run shows current config and asks what to update). Supports --reset to clear and start fresh. ## onboarding-check.sh update Changed detection from the gitignored .claude/session/onboarded marker to checking onboarding.yaml for placeholder values (grep for "Your Company Name"). The config file IS the flag — committed, persists across clones, no hidden state. New users see "run /setup"; configured forks see nothing. ## /onboard deprecation Replaced the 130-line discovery flow with a redirect page pointing at /setup (framework config) and /handover (project config). The split resolves the mixed-concerns problem: framework bootstrap and per-project discovery are different flows that happen at different times, write to different files, and have different triggers. ## CLAUDE.md updates - Skills table: 13 → 17 (added /setup, /start-ticket, /approve-merge, /approve-design; /onboard still listed but marked deprecated) - Hooks description: updated count and expanded capability summary - Rules count: 9 (added ticket-vocabulary.md) - Settings description: now mentions PostToolUse and SessionStart events in addition to PreToolUse Closes #32 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
atlas-apex
commented
Apr 12, 2026
atlas-apex
left a comment
Collaborator
Author
There was a problem hiding this comment.
Code Review: PR #33
Commit: 16ffd6eb2d2e753baea8c9014cb44ed458e39396
Summary
Replaces sequential /onboard with a 3-exchange /setup skill. Hook now checks committed onboarding.yaml instead of a gitignored session marker. Clean separation: /setup = framework, /handover = project.
Checklist Results
- N/A Architecture & DDD: docs/config only
- ✅ Code Quality: clear, well-structured
- N/A Testing: no runtime code
- ✅ Security: no secrets, no injection vectors
- N/A Performance: shell + markdown only
- ✅ PR Description & Glossary: present and thorough
- ✅ Technical Decisions (AgDR): N/A — no library/framework choices
Issues Found
- Hook grep pattern mismatch —
onboarding-check.shgreps for"Your Company Name"(double quotes), but YAML files typically use unquoted or single-quoted strings. Verify the templateonboarding.yamluses exactly that double-quoted form, otherwise the hook will silently pass on unconfigured forks.
Suggestions
- Minor: the
exit 0after thefiblock runs even on the prompt path — harmless but the exit could move inside the else branch for clarity.
Verdict
COMMENT — one item to verify (grep pattern vs actual template format), otherwise clean.
🤖 Reviewed by Rex (Code Reviewer Agent)
📌 Reviewed commit: 16ffd6eb2d2e753baea8c9014cb44ed458e39396
me2resh
approved these changes
Apr 12, 2026
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New `/setup` skill for first-run bootstrap — "describe your stack, accept defaults, done in 3 exchanges." Replaces the 7-question sequential `/onboard` flow. `onboarding-check.sh` now checks `onboarding.yaml` (committed) instead of a gitignored session marker.
Closes #32
Design
Changes
Glossary
Test plan
🤖 Generated with Claude Code