Conversation
Member
|
It looks like this is something we'd need to support page queries in gatsby-mdx since right now the graphql tagged template literal is getting mangled as an inline-code element. |
This was referenced Jul 23, 2018
Member
|
This totally worked for us :D thanks! |
johno
added a commit
that referenced
this pull request
Jul 25, 2018
* Spike out using custom tokenizer in remark parser * Make import/export parsing more robust * Revert unused change in mdxast test * Move empty newline to utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we relied 100% on remark's default parser which got us to an MVP but doesn't quite cut it due to the added syntax that imports, exports, and JSX. In many areas that syntax directly conflicts with MD syntax.
For example, consider the following export:
The template string, url, and array conflict with Markdown parsing. This expected/intended behavior from an MD perspective, but not from an ES export. This occurs because the paragraph tokenizer then passes the parsed paragraph text on to inline tokenizers in order to parse links, inline code, emphasis, etc.
So we're now introducing our own block parsers that inject themselves before the HTML/paragraph block tokenizers that skip inline tokenization and pass along the raw values for imports/exports. Note that this is still a WIP
Also, I'd like to explicitly thank @wooorm for providing a wonderfully extensible library that allows us to do whacky things 💟.