Spec section: Avoid dupe titles; treat anchors as optional#3746
Conversation
|
Before After For the record, I don't understand what the |
hm, some fancy things happened to white space during the commit. I'll look into it.
Yeah, I reckon this would be better. I just learned last week that there is another package that provides this text: https://github.com/w3c/webref/blob/master/ed/headings/tc39-relative-indexing-method.json#L8 So, I think we probably want to follow-up and also integrate the webref package. (which is a bit larger package, but it contains many useful things for us. We also figured we can probably retire mdn/data and use webref, so that would be really cool then). |
peterbe
left a comment
There was a problem hiding this comment.
If you can merge in https://github.com/Elchi3/yari/pull/337 I can take another closer look.
So the "Additions to Properties of the Array Prototype Object" stuff isn't available. OK. |
…ull3746 review on #3746
Yup, good point. The old tables do that, too, that's why I preserved it. I guess it is there to stress the fact that it is a deep link into the specification but I'm also not sure how useful it really is. It doesn't add that much value for sure now that's just the anchor and no proper link text (yet). |
* Spec section: Avoid dupe titles; treat anchors as optional * review on mdn#3746 Co-authored-by: Peter Bengtsson <mail@peterbe.com>
It was a bit naive to think that we will find anchored links for all specification urls.
There are in fact a few features that won't have it, see mdn/browser-compat-data#10353
So, the renderer should check if it is there and only then display the anchor.
The other change is duplicate titles: Sometimes the w3c/browser-specs package uses the same
titleandshortTitle. Displaying both looks weird. So, we shouldn't do that. Test case: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at#specifications