Skip to content
This repository was archived by the owner on Jun 21, 2022. It is now read-only.

Conversation

@mfluehr
Copy link
Contributor

@mfluehr mfluehr commented Oct 6, 2017

No description provided.

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the data, LGTM,r+, the changes make sense and are coherent with mdn/data but, once the linter will pass without errors, I would like a second opinion as it touches non-data macros (@Elchi3 ?)

"custom-ident": {},
"filter-function": {
"title": s_possible_values + "blur(), brightness(), contrast(), drop-shadow(), grayscale(), hue-rotate(), invert(), opacity(), saturate(), sepia()"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need a comma here

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the missing comma. Thank you mfluehr, good job!

@teoli2003 teoli2003 merged commit a2c926d into mdn:master Oct 9, 2017
jwhitlock added a commit to mdn/kuma that referenced this pull request Oct 9, 2017
* mdn/kumascript#338 - GroupData: Fetch Abort spec update
* mdn/kumascript#339 - GroupData: add MediaRecorderErrorEvent
* mdn/kumascript#341 - GamepadEventProperties: Fix typo
* mdn/kumascript#342 - CSS_Ref, csssyntax: filter-function update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants