This repository was archived by the owner on Jun 21, 2022. It is now read-only.
Use footnotes for alternative_name #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
approved these changes
Sep 20, 2017
Member
Elchi3
left a comment
There was a problem hiding this comment.
Just one nit, see the BCD PR for a more detailed comment.
macros/Compat.ejs
Outdated
| } | ||
| // collect alternative names | ||
| if (supportEntry.hasOwnProperty('alternative_name')) { | ||
| let flagNote = writeAlternativeNameNote(supportEntry.alternative_name); |
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Sep 25, 2017
* mdn/kumascript#321 - Compat: Use footnotes for alternate name * mdn/kumascript#322 - WebExtAllCompatTables: aggregation of privacy features * mdn/kumascript#326 - Compat: Update for BCD v0.0.7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a fix for #318. I've tested it locally with aggregate and non-aggregate tables, and verified that the alternative_name is now shown in a footnote.