This repository was archived by the owner on Jun 21, 2022. It is now read-only.
bug 1398947: use KS_VERSION instead of VERSION #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use KS_VERSION instead of VERSION when running "make build-kumascript" and "make push-kumascript"
jwhitlock
added a commit
to mdn/kuma
that referenced
this pull request
Sep 18, 2017
* mdn/kumascript#312 - Fix Jenkins image building * mdn/kumascript#313 - SeeCompatTable: Def. of experimental * mdn/kumascript#314 - SpecName, spec2: Intersection Observer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Jenkins build/push pipeline for the Kumascript master branch (see https://ci.us-west.moz.works/blue/organizations/jenkins/kumascript_multibranch_pipeline/detail/master/187/pipeline). When running the "build-kumascript" and "push-kumascript" commands within the Kuma-based Makefile, we were using
VERSION=latestwhen we should have been usingKS_VERSION=latest. This resulted in running the Kumascript tests (make test VERSION=latest) against an image different from the one just built usingmake build-kumascript VERSION=latest.