Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Issue 561 Added example for vertical-align in text context #606

Merged
wbamberg merged 6 commits into from
Feb 23, 2018
Merged

Issue 561 Added example for vertical-align in text context #606

wbamberg merged 6 commits into from
Feb 23, 2018

Conversation

@LLyaudet
Copy link
Contributor

@LLyaudet LLyaudet commented Feb 22, 2018

Hello @wbamberg,
Here is the pull request for vertical-align. I put my commit in a branch issue-561-css-vertical-align if there is any correction to add to the branch.
Best regards,
Laurent Lyaudet

@welcome
Copy link

welcome bot commented Feb 22, 2018

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line: - If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

Merge remote-tracking branch 'upstream/master' into issue-561-css-ver…
d938330 
…tical-align

* upstream/master:
  Logical properties (mdn#598)
  Revert "Adds next iteration of the HTML interactive editor (mdn#576)" (mdn#605)
wbamberg
wbamberg suggested changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works great :).

I pushed a merge from the latest master, because the master you started from had a problem which stopped the example from working.

Apart from that, the only thing I can see is that this example doesn't belong in the "text" directory. We are trying to organize CSS examples by the specification that defines them, and I think "inline-layout" would be the right directory for this property, mapping to https://drafts.csswg.org/css-inline/.

@LLyaudet
Copy link
Contributor Author

LLyaudet commented Feb 23, 2018

Hello @wbamberg,
I pushed the commit for moving the source in a new directory inline-layout under css-examples.
I modified meta.json in text directory and created one such file in inline-layout directory.
Is there anything else to do to have the inline-layout examples up and running ?
There is also merge commits since I messed up by fetching upstream and merging from upstream master into my branch instead of pulling my branch with the merge you did from my fork.
I need practice on this. That's my first pull request.
Best regards,
Laurent Lyaudet

@wbamberg
Copy link
Contributor

wbamberg commented Feb 23, 2018

This looks fine! Just you forgot to update the paths inside meta.json when you moved the files from "text" to "inline-layout". I just pushed a commit taking care of that. I also made the CSS selector more specific - as you pointed out before, it is possible for styles in here to interfere with the whole example - they don't in this particular case, but still it seems like a good idea to avoid that possibility.

wbamberg
wbamberg approved these changes Feb 23, 2018
View reviewed changes
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @LLyaudet !

@wbamberg wbamberg merged commit 70df944 into mdn:master Feb 23, 2018
@welcome
Copy link

welcome bot commented Feb 23, 2018

Congrats on merging your first pull request! 🎉🎉🎉

@wbamberg
Copy link
Contributor

wbamberg commented Feb 24, 2018

I've just updated the page: https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align :)

@wbamberg wbamberg mentioned this pull request Feb 24, 2018
Closed
@LLyaudet LLyaudet deleted the issue-561-css-vertical-align branch February 24, 2018 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wbamberg wbamberg wbamberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LLyaudet @wbamberg