Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Revert "Adds next iteration of the HTML interactive editor (#576)" #605

Merged
wbamberg merged 1 commit into from
Feb 22, 2018
Merged

Revert "Adds next iteration of the HTML interactive editor (#576)" #605

wbamberg merged 1 commit into from
Feb 22, 2018

Conversation

@bookshelfdave
Copy link
Contributor

@bookshelfdave bookshelfdave commented Feb 22, 2018

This reverts commit 432e90b.

@bookshelfdave
Copy link
Contributor Author

bookshelfdave commented Feb 22, 2018

See #604

@wbamberg
Copy link
Contributor

wbamberg commented Feb 22, 2018

This reverts the change to add the HTML editor, because that change breaks the CSS examples. I think it's due to this line: https://github.com/mdn/interactive-examples/blob/master/js/editor-libs/tabby.js#L3, which assumes the previous line does not return null - but it does, I guess because the HTML editor is not defined in CSS examples.

So the example looks like this:
screen shot 2018-02-22 at 12 41 23 pm

@wbamberg wbamberg merged commit fead961 into master Feb 22, 2018
@bookshelfdave bookshelfdave deleted the dp_revert_pr_576 branch February 22, 2018 20:43
wbamberg pushed a commit to LLyaudet/interactive-examples that referenced this pull request Feb 23, 2018
Merge remote-tracking branch 'upstream/master' into issue-561-css-ver…
d938330 
…tical-align

* upstream/master:
  Logical properties (mdn#598)
  Revert "Adds next iteration of the HTML interactive editor (mdn#576)" (mdn#605)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wbamberg wbamberg wbamberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bookshelfdave @wbamberg