Add optional annotation to parameters in FontFaceSet methods#44352
Merged
chrisdavidmills merged 3 commits intoJun 9, 2026
Conversation
This commit updates the following pages: - https://developer.mozilla.org/en-US/docs/Web/API/FontFaceSet/check - https://developer.mozilla.org/en-US/docs/Web/API/FontFaceSet/forEach - https://developer.mozilla.org/en-US/docs/Web/API/FontFaceSet/load Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Contributor
|
Preview URLs (3 pages)
External URLs (2)URL:
URL:
(comment last updated: 2026-06-09 08:02:31) |
chrisdavidmills
requested changes
Jun 8, 2026
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @Juneezee. I've got some comments for you.
Reference: #44352 (review) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Juneezee
commented
Jun 8, 2026
Juneezee
left a comment
Contributor
Author
There was a problem hiding this comment.
@chrisdavidmills Thanks for reviewing the PR. I have addressed your comments and the changes are ready for your review.
| - : limit the font faces to those whose Unicode range contains at least one of the characters in text. This [does not check for individual glyph coverage](https://lists.w3.org/Archives/Public/www-style/2015Aug/0330.html). | ||
| - : A font specification using the syntax for the CSS {{cssxref("font")}} property, for example `"italic bold 16px Roboto"` | ||
| - `text` {{optional_inline}} | ||
| - : Limit the font faces to those whose Unicode range contains at least one of the characters in text. This [does not check for individual glyph coverage](https://lists.w3.org/Archives/Public/www-style/2015Aug/0330.html). Defaults to [a string containing a single space character (U+0020 SPACE) `" "`](https://drafts.csswg.org/css-font-loading/#find-the-matching-font-faces). |
Contributor
Author
There was a problem hiding this comment.
Let me know if you think it is better to inform the user about this default value via an alert
Note
According to CSS Font Loading Module Level 3 specification,
- If text was not explicitly provided, let it be a string containing a single space character (U+0020 SPACE).
Contributor
There was a problem hiding this comment.
No, what you've done is fine, although see my comments.
chrisdavidmills
requested changes
Jun 9, 2026
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
@Juneezee, a couple more comments for you. Nearly there!
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
chrisdavidmills
approved these changes
Jun 9, 2026
chrisdavidmills
left a comment
Contributor
There was a problem hiding this comment.
OK, this looks ready to merge. Thanks again, @Juneezee!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the following pages to include the inline Optional label for their optional parameters:
Motivation
Adding the Optional label improves readability, prevents confusion about which arguments are strictly required, and maintains consistency with the rest of the MDN Web API reference pages.
Additional details
Related issues and pull requests