Skip to content

feat(jsondata): add external_link translation key#43978

Merged
caugner merged 2 commits intomainfrom
rari-266-add-external-link-l10n-key
May 6, 2026
Merged

feat(jsondata): add external_link translation key#43978
caugner merged 2 commits intomainfrom
rari-266-add-external-link-l10n-key

Conversation

@caugner
Copy link
Copy Markdown
Collaborator

@caugner caugner commented Apr 30, 2026

Summary

Adds a new external_link key to L10n-Template.json, used by rari to set a localized title attribute on external links for accessibility.

Companion PR: mdn/rari#658 (resolving mdn/rari#266)

English value: External link (opens in new tab).

Translations

Translations are provided as starting drafts and need review by L10n maintainers for each locale (de, es, fr, ja, ko, pt-BR, ru, zh-CN, zh-TW).

Test plan

  • JSON validates
  • L10n maintainers review translations

@github-actions github-actions Bot added the size/s [PR only] 6-50 LoC changed label Apr 30, 2026
Comment thread files/jsondata/L10n-Template.json
Comment thread files/jsondata/L10n-Template.json
Comment thread files/jsondata/L10n-Template.json
Comment thread files/jsondata/L10n-Template.json
"ja": "外部リンク(新しいタブで開きます)",
"ko": "외부 링크 (새 탭에서 열림)",
"pt-BR": "Link externo (abre em uma nova aba)",
"ru": "Внешняя ссылка (открывается в новой вкладке)",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/ru-content

Comment thread files/jsondata/L10n-Template.json
"fr": "Lien externe (ouvre un nouvel onglet)",
"ja": "外部リンク(新しいタブで開きます)",
"ko": "외부 링크 (새 탭에서 열림)",
"pt-BR": "Link externo (abre em uma nova aba)",
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdn/pt-br-content

Comment thread files/jsondata/L10n-Template.json Outdated
@caugner caugner marked this pull request as ready for review May 4, 2026 16:05
@caugner caugner requested a review from a team as a code owner May 4, 2026 16:05
@caugner caugner requested review from LeoMcA and removed request for a team May 4, 2026 16:05
Comment thread files/jsondata/L10n-Template.json
@caugner
Copy link
Copy Markdown
Collaborator Author

caugner commented May 6, 2026

FYI - I'm going to merge this later today.

@caugner caugner merged commit 80a0908 into main May 6, 2026
10 checks passed
@caugner caugner deleted the rari-266-add-external-link-l10n-key branch May 6, 2026 13:19
pepelsbey added a commit to pepelsbey/mdn-content that referenced this pull request May 6, 2026
* upstream/main: (150 commits)
  PWA relative links (mdn#43953)
  feat(jsondata): add `external_link` translation key (mdn#43978)
  Clarify when var() falls back to its second argument (mdn#44015)
  Correct incorrect filename on learn assessment (mdn#44012)
  FF151 Relnote CanvasRenderingContext2D.lang (mdn#44010)
  FF151: Update container style queries support (mdn#44002)
  Firefox experimental features clean-up (mdn#43887)
  FF151 Relnote: shadowrootslotassignment (mdn#43881)
  Editorial review: Document WebGPU compatibility mode (mdn#43944)
  Correction of solution (mdn#44001)
  Synchronize with BCD v7.3.14 (mdn#44007)
  Editorial review: Document texture_and_sampler_let WGSL feature (mdn#43768)
  Editorial review: Document NavigationTransition.committed (mdn#43692)
  Update window.open on document / window creation and load behavior (mdn#43913)
  FF151 Relnote: keyboardLock option for Element.requestFullScreen() (mdn#43883)
  FF118 keyboard value for Window Event tidy (mdn#43942)
  Bump yaml from 2.8.3 to 2.8.4 (mdn#44005)
  Rename Stylesheet glossary definition to Style sheet (mdn#43997)
  Clarify else-if evaluation order (mdn#43917)
  chore(dictionaries): add technical terms flagged by spelling check (mdn#43907)
  ...

# Conflicts:
#	files/en-us/web/api/svgscriptelement/async/index.md
#	files/en-us/web/api/svgscriptelement/index.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants