Remove incorrect detail for drop-shadow syntax#43324
Merged
hamishwillee merged 2 commits intomdn:mainfrom Mar 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a misleading statement in the MDN drop-shadow() documentation that implied missing length values default to 0, which could be read as allowing omitted offset values even though drop-shadow() requires at least two lengths.
Changes:
- Deletes the sentence claiming missing
<length>values default to0in the<length>parameter description.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hamishwillee
approved these changes
Mar 6, 2026
Collaborator
hamishwillee
left a comment
There was a problem hiding this comment.
@mateuszJS - I completely agree. Thank you.
jdatapple
pushed a commit
to jdatapple/content
that referenced
this pull request
Mar 6, 2026
remove misleading ifnormation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Misleading information that filter: drop-shadow uses
0for offset length if value is not provided.drop-shadowwith one<length>is invalid. Additionally, on the start of the paragraph it's specified that 2 or 3 values are accepted, so it's impossible to omit x or y offset. In my opinion, the paragraph without that sentence describes the behaviour in a bit cleaner way.Additional details
I assume it was copy-pasted from spec:
The default value for omitted values is missing length values set to 0 and the missing used color is taken from the color property.. From the spec perspective it might be technically correct that0is used by default and it's later interpreted as no gaussian blur but from developer friendly docs it introduces a bit more confusion than help.Let me know if you agree.