added links to the supported calendar types#39471
Merged
Conversation
Contributor
Josh-Cena
reviewed
May 10, 2025
Member
There was a problem hiding this comment.
If you want to do this, could you make sure this link is added to the withCalendar, from, and constructor pages of every object?
My intention is for the calendarId page to be the single source of truth documenting which calendar IDs are valid for each object type, although incidentally they all match Intl.supportedValuesOf, but I don't think that's normatively required.
Josh-Cena
reviewed
May 12, 2025
files/en-us/web/javascript/reference/global_objects/temporal/plaindate/withcalendar/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
May 13, 2025
files/en-us/web/javascript/reference/global_objects/temporal/plainyearmonth/tostring/index.md
Outdated
Show resolved
Hide resolved
This was referenced May 14, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
calendartypes to:Motivation
withCalendar()method and what calendar type can be used.Related issues and pull requests
PlainDateTimeBCD PRPlainDateBCD PR