Firefox doesn't support some calendars for Temporal.PlainDate.withCalendar()#26758
Merged
Firefox doesn't support some calendars for Temporal.PlainDate.withCalendar()#26758
Temporal.PlainDate.withCalendar()#26758Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Temporal.PlainDate.withCalendar()
caugner
requested changes
May 9, 2025
Contributor
caugner
left a comment
There was a problem hiding this comment.
LGTM overall.
However:
- The note is missing
chineseanddangi(unless these were re-enabled in a different bug?). - Is there any other method affected by this?
| "version_added": "139" | ||
| "version_added": "139", | ||
| "partial_implementation": true, | ||
| "notes": "The following calendars are not yet support `islamic`, `islamic-rgsa` and `islamic-umalqura`. See [bug 1950425](https://bugzil.la/1950425)." |
Contributor
There was a problem hiding this comment.
Suggested change
| "notes": "The following calendars are not yet support `islamic`, `islamic-rgsa` and `islamic-umalqura`. See [bug 1950425](https://bugzil.la/1950425)." | |
| "notes": "Calendars `chinese`, `dangi`, `islamic`, `islamic-rgsa` and `islamic-umalqura` are not available. See [bug 1950425](https://bugzil.la/1950425)." |
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Ah, looks like mozilla/gecko-dev@4618744 as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1954138 is the explanation:
Bug 1954138 - Part 9: Re-enable Chinese and Dangi calendars even when not Nightly.
caugner
approved these changes
May 9, 2025
Contributor
caugner
left a comment
There was a problem hiding this comment.
LGTM, just an optional suggestion to link to both relevant bugs.
(Feel free to dismiss, I will merge before the next BCD release on Tuesday.)
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
approved these changes
May 13, 2025
This was referenced May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withCalendarmethod inPlainDateTest results and supporting details
Related issues
PlainDateTimeBCD PR