Compression Dictionary Transport updates#38974
Conversation
|
Preview URLs
Flaws (1)Note! 3 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2025-04-09 11:02:01) |
|
This is a minor point. https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel does not link to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/compression-dictionary. Could you link to it somehow, such as in the table (following |
Done! |
…hub.com/tunetheweb/content into compresson-dictionary-transport-sidebar
wbamberg
left a comment
There was a problem hiding this comment.
I just had one comment on the spec/BCD additions - we don't generally include this in guide pages.
I'll leave the comments on DictionaryId to @hamishwillee because it was his comment :).
| status: | ||
| - experimental | ||
| browser-compat: | ||
| - html.elements.link.rel.compression-dictionary | ||
| - http.headers.Accept-Encoding.dcb | ||
| - http.headers.Accept-Encoding.dcz | ||
| - http.headers.Available-Dictionary | ||
| - http.headers.Content-Encoding.dcb | ||
| - http.headers.Content-Encoding.dcz | ||
| - http.headers.Dictionary-ID | ||
| - http.headers.Use-As-Dictionary | ||
| spec-urls: https://datatracker.ietf.org/doc/html/draft-ietf-httpbis-compression-dictionary |
There was a problem hiding this comment.
We don't generally include spec tables or BCD in guide pages, only in reference pages.
There was a problem hiding this comment.
That's what I thought too — hence why I didn't include it originally.
However, I noticed for Permissions Policy we do include these.
I think that while a technology is "experimental" (like Permissions Policy and Compression Dictionary Transport are) that's a pretty good idea to mark it as such and include the full things.
The rest of the HTTP guides really are for core concepts that are supported by all browsers, so including BCD is not really necessary — though specs still seem like good ideas to me in some case. The only other similar case (that probably should be marked as experimental and treated similarly) is HTTP Client Hints, but will leave that for now and stick to Compression Dictionary Transport for this PR.
WDYT?
There was a problem hiding this comment.
@wbamberg I looked at the bits that were associated with other work I am doing, but not the rest since you reviewed that.
This bit is the only outstanding discussion and is waiting on you.
FWIW We are not consistent on this. I think the rule is understood, but isn't followed because it isn't that helpful to readers.
There was a problem hiding this comment.
I've tried to ask for more feedback from other maintainers on this but not got much in the way of definitive responses.
But I'm tired of arguing about consistency and structure, and I don't think there's anything to say that hasn't already been said, so I'm not going to block the PR on this.
There was a problem hiding this comment.
Fair enough. I tend to accept things if I think they are good or not actively harmful in cases like this. Not worth banging your head against the wall for.
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thank you! There's enough eyes on this so I'm taking myself off review 🙏🏻 |
* Fix Compression Dictionary Transport sidebar and add more front matter * Add mroe BCD to guide and explain Dictionary Id better * Tweaks * review-feedback * linting * Review-feedback * Update files/en-us/web/http/reference/headers/dictionary-id/index.md Co-authored-by: Hamish Willee <hamishwillee@gmail.com> * Update files/en-us/web/http/reference/headers/dictionary-id/index.md Co-authored-by: Hamish Willee <hamishwillee@gmail.com> * Update files/en-us/web/http/reference/headers/dictionary-id/index.md * Update files/en-us/web/http/reference/headers/dictionary-id/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: Hamish Willee <hamishwillee@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Brian Smith <brian@smith.berlin>
Description
Follow on from #38722 (reviewed by @wbamberg ) I noticed the new guide wasn't showing in the sidebar.
I've also added more front matter to flag this as experimental and also add Spec and Compatibility table.
Finally, I've also added a bit more explanation of
id/Dictionary-IDas raised at #38948 (comment) by @hamishwilleeMotivation
More helpful to devs when viewing the guide.
Additional details
Related issues and pull requests
An update to #38722
Also discussed in #38948