chore(http): Refresh some headers pages (~a-c)#36038
Merged
Conversation
Contributor
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
This was referenced Sep 27, 2024
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
dipikabh
requested changes
Oct 22, 2024
Contributor
dipikabh
left a comment
There was a problem hiding this comment.
Reviewed till accept-patch. I'll look at the remaining files tomorrow.
| - : Any value placed in an order of preference expressed using a relative {{Glossary("Quality values", "quality value")}} called _weight_. | ||
|
|
||
| ## Examples | ||
|
|
Contributor
There was a problem hiding this comment.
Would be nice to add an H3 and some prose here
…x.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
bsmth
commented
Oct 23, 2024
files/en-us/web/http/headers/access-control-allow-headers/index.md
Outdated
Show resolved
Hide resolved
dipikabh
requested changes
Oct 23, 2024
Contributor
dipikabh
left a comment
There was a problem hiding this comment.
Reviewed till content-location
files/en-us/web/http/headers/attribution-reporting-eligible/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-source/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/attribution-reporting-register-trigger/index.md
Outdated
Show resolved
Hide resolved
dipikabh
requested changes
Oct 25, 2024
files/en-us/web/http/headers/content-security-policy-report-only/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/content-security-policy-report-only/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
Author
|
Thank you @dipikabh - I have some suggestions from you to work on. I will re-request when it's ready for another look 👀 |
Contributor
|
@bsmth, you might want to look into this "Browser compatibility" section verbiage I came across in our page templates: https://developer.mozilla.org/en-US/docs/MDN/Writing_guidelines/Page_structures/Page_types/HTTP_header_page_template#browser_compatibility |
Member
Author
|
@dipikabh I think this one's ready for another look 👀 |
Member
Author
|
Thank you, Dipika 🙏🏻 |
fiji-flo
pushed a commit
that referenced
this pull request
Oct 31, 2024
* chore(http): Refresh headers docs * chore(http): Refresh headers docs * chore(http): Refresh headers docs * chore(http): Remove bogus Content-Location header example * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * chore(http): Add glossary links to request and response header terms * Update files/en-us/web/http/headers/access-control-allow-headers/index.md Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * chore(http): Changes following reviewer feedback * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * Apply suggestions from code review Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> * Update files/en-us/web/http/headers/clear-site-data/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore(http): Changes following reviewer feedback * chore(http): Changes following reviewer feedback * chore(http): Changes following reviewer feedback * chore(http): Changes following reviewer feedback * chore(http): Glossary links to request / response headers --------- Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refreshes a few HTTP headers pages.
common changes:
The HTTP **`Header-Name`** (request|response) headerin first sentence{{HTTPStatus("406", "406 Not Acceptable")}}Motivation
Keeping content up-to-date, fixing formatting, unifying writing conventions
Notes
http.headers.Content-Digest