Skip to content

Importmap integrity section#33712

Merged
chrisdavidmills merged 15 commits intomdn:mainfrom
yoavweiss:main
May 31, 2024
Merged

Importmap integrity section#33712
chrisdavidmills merged 15 commits intomdn:mainfrom
yoavweiss:main

Conversation

@yoavweiss
Copy link
Copy Markdown
Contributor

Description

SRI support for ES module imports would enable using them in documents that require SRI for certain scripts for security or privacy reasons.

See problem statement and proposal by @guybedford.

This PR adds a description of the added section, to help developers make use of it.

whatwg/html#10269
Chromium CL + tests
WebKit PR

Motivation

Document the newly added integrity section in import maps.

Additional details

Related issues and pull requests

Fixes mdn/mdn#541

@yoavweiss yoavweiss requested a review from a team as a code owner May 22, 2024 07:14
@yoavweiss yoavweiss requested review from chrisdavidmills and removed request for a team May 22, 2024 07:14
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed labels May 22, 2024
yoavweiss and others added 3 commits May 22, 2024 09:15
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 22, 2024

Preview URLs

(comment last updated: 2024-05-22 13:37:34)

Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yoavweiss, this looks great. I just had a few language suggestions for you to look over, but nothing major.

Question — have you submitted a corresponding https://github.com/mdn/browser-compat-data PR for this? It would be good to list it as a subfeature in the compat table.

yoavweiss and others added 8 commits May 22, 2024 12:55
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@yoavweiss
Copy link
Copy Markdown
Contributor Author

Question — have you submitted a corresponding https://github.com/mdn/browser-compat-data PR for this? It would be good to list it as a subfeature in the compat table.

I put together an initial PR, but it seems like it needs:

  • The HTML PR to land
  • Definitive version for WebKit support, which I'm not sure how to get for a PR that just landed.

@yoavweiss yoavweiss requested a review from chrisdavidmills May 22, 2024 12:24
Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, nice work @yoavweiss. I did a couple of further small language fixes, and now I think its GTG.

I'll leave it unmerged until we've got the compat data sorted out.

@yoavweiss
Copy link
Copy Markdown
Contributor Author

I'll leave it unmerged until we've got the compat data sorted out.

Sounds good, thanks! :)

@yoavweiss
Copy link
Copy Markdown
Contributor Author

Compat data is good to go (I think) at mdn/browser-compat-data#23153

@chrisdavidmills
Copy link
Copy Markdown
Contributor

Compat data is good to go (I think) at mdn/browser-compat-data#23153

Great; I've merged the BCD. Now we just need to wait until the BCD update is slurped into MDN, which usually only takes a day, I think. OR, we could just merge this now, if you don't mind a small risk that it might show without any BCD or spec table for a very short while.

@yoavweiss
Copy link
Copy Markdown
Contributor Author

Great; I've merged the BCD. Now we just need to wait until the BCD update is slurped into MDN, which usually only takes a day, I think. OR, we could just merge this now, if you don't mind a small risk that it might show without any BCD or spec table for a very short while.

No strong opinion, so I'll leave the decision up to you! :)

@chrisdavidmills
Copy link
Copy Markdown
Contributor

Great; I've merged the BCD. Now we just need to wait until the BCD update is slurped into MDN, which usually only takes a day, I think. OR, we could just merge this now, if you don't mind a small risk that it might show without any BCD or spec table for a very short while.

No strong opinion, so I'll leave the decision up to you! :)

Let's dooooooooo it ;-)

@chrisdavidmills chrisdavidmills merged commit fbcfa61 into mdn:main May 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Content:HTML Hypertext Markup Language docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for subresource integrity in imported module scripts

2 participants