Skip to content

Add importmap integrity subsection#23153

Merged
chrisdavidmills merged 5 commits intomdn:mainfrom
yoavweiss:main
May 31, 2024
Merged

Add importmap integrity subsection#23153
chrisdavidmills merged 5 commits intomdn:mainfrom
yoavweiss:main

Conversation

@yoavweiss
Copy link
Copy Markdown
Contributor

@yoavweiss yoavweiss commented May 22, 2024

Summary

Add an integrity subsection to importmap script type.

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label May 22, 2024
yoavweiss
yoavweiss commented May 22, 2024
View reviewed changes
yoavweiss
yoavweiss commented May 22, 2024
View reviewed changes
yoavweiss
yoavweiss commented May 22, 2024
View reviewed changes
@yoavweiss yoavweiss requested a review from chrisdavidmills May 31, 2024 03:02
yoavweiss
yoavweiss commented May 31, 2024
View reviewed changes
html/elements/script.json
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
Copy link
Copy Markdown
Contributor Author

@yoavweiss yoavweiss May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdavidmills I've put Safari as "false" as @marcoscaceres suggested, as that's the most accurate description. At the same time, it might be useful to include slightly broader data regarding "available in webkit nightly" and "available in Safari Tech Preview" (not related to this specific feature, but in general)

Copy link
Copy Markdown
Contributor Author

@yoavweiss yoavweiss May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #23217

@yoavweiss
Copy link
Copy Markdown
Contributor Author

yoavweiss commented May 31, 2024

I'm getting a build error - Error: Could not find source release "chrome 127"!

At the same time, the feature has landed in Chromium's main branch before M127's branch point. What should the data indicate in such a case? Or should we just wait until 127 branches?

@github-actions github-actions bot added the data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. label May 31, 2024
@yoavweiss
Copy link
Copy Markdown
Contributor Author

yoavweiss commented May 31, 2024

I'm getting a build error - Error: Could not find source release "chrome 127"!

At the same time, the feature has landed in Chromium's main branch before M127's branch point. What should the data indicate in such a case? Or should we just wait until 127 branches?

NM, added it as "nightly".

@yoavweiss yoavweiss mentioned this pull request May 31, 2024
Merged
chrisdavidmills
chrisdavidmills approved these changes May 31, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @yoavweiss !

@chrisdavidmills chrisdavidmills merged commit 3f8e53a into mdn:main May 31, 2024
@yoavweiss
Copy link
Copy Markdown
Contributor Author

yoavweiss commented Jun 11, 2024

It looks like the feature made it into Safari 18's beta
Should I file a PR to update that part?

@bsmth bsmth mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills approved these changes

+1 more reviewer

@marcoscaceres marcoscaceres marcoscaceres left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoavweiss @chrisdavidmills @marcoscaceres