Separate popover's light dismiss from Esc button close request#30890
Merged
hamishwillee merged 3 commits intomdn:mainfrom Dec 11, 2023
Merged
Conversation
Contributor
|
Preview URLs (comment last updated: 2023-12-11 00:15:51) |
hamishwillee
approved these changes
Dec 11, 2023
Collaborator
hamishwillee
left a comment
There was a problem hiding this comment.
Thank you very much. I slightly amended the second point because "close requests" is not well defined (even though pretty clear what it means).
Contributor
|
@hamishwillee fwiw "close requests" is the html spec language. But till it's documented on MDN this is fine. |
dipikabh
pushed a commit
to dipikabh/content
that referenced
this pull request
Jan 17, 2024
…0890) * Separate popover light dismiss from Esc button close request * Update files/en-us/web/api/popover_api/using/index.md * Update files/en-us/web/api/popover_api/using/index.md --------- Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes #30309
It divides the bullet point about light dismissing the popover into two: One for light dismiss as clicking outside of the modal, and the second for closing the modal by sending close request mentioning pressing Esc button as one of those close requests.