Add recommendation for selecting HTML id attribute#25292
Merged
Conversation
Contributor
|
Preview URLs External URLs (2)URL:
(comment last updated: 2023-04-14 05:52:24) |
Josh-Cena
reviewed
Mar 13, 2023
estelle
reviewed
Mar 13, 2023
estelle
reviewed
Mar 13, 2023
estelle
reviewed
Mar 13, 2023
Member
estelle
left a comment
There was a problem hiding this comment.
some suggestions. I need to investigate hyphens, so will comment again.
estelle
reviewed
Mar 13, 2023
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
teoli2003
commented
Mar 31, 2023
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
teoli2003
commented
Mar 31, 2023
teoli2003
commented
Mar 31, 2023
Contributor
Author
|
Ready for a 2nd pass. |
Josh-Cena
reviewed
Apr 1, 2023
Member
Josh-Cena
left a comment
There was a problem hiding this comment.
Mostly LGTM, with a few rewording
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Josh-Cena
reviewed
Apr 1, 2023
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Contributor
Author
|
Fun note: it is fascinating how an initially simple issue leads to digging into dark corners of the web platform. |
Member
|
The original author of this note probably dug through this themselves, they just didn't spell it out exactly ^^ |
estelle
approved these changes
Apr 14, 2023
Member
estelle
left a comment
There was a problem hiding this comment.
Grammatical tweaks. Approved.
Mehrm0
pushed a commit
to Mehrm0/content
that referenced
this pull request
Apr 14, 2023
* Add recommendation for selecting HTML id attribute * Update files/en-us/web/html/global_attributes/id/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * Update files/en-us/web/html/global_attributes/id/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * Fix Markdownlint flaw * Update files/en-us/web/html/global_attributes/id/index.md Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> * Update files/en-us/web/html/global_attributes/id/index.md * Fix Markdownlint flaw * Update files/en-us/web/html/global_attributes/id/index.md * Update files/en-us/web/html/global_attributes/id/index.md Co-authored-by: Joshua Chen <sidachen2003@gmail.com> * Update files/en-us/web/html/global_attributes/id/index.md Co-authored-by: Joshua Chen <sidachen2003@gmail.com> * Update files/en-us/web/html/global_attributes/id/index.md Co-authored-by: Joshua Chen <sidachen2003@gmail.com> * Update files/en-us/web/html/global_attributes/id/index.md * Update files/en-us/web/html/global_attributes/id/index.md --------- Co-authored-by: Estelle Weyl <estelle@openwebdocs.org> Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25200
Further improvements are welcome.