Redirect Document DnD events to HTMLElement#20206
Merged
Conversation
teoli2003
approved these changes
Sep 1, 2022
Contributor
teoli2003
left a comment
There was a problem hiding this comment.
This makes sense to me.
teoli2003
suggested changes
Sep 1, 2022
This reverts commit 5c655b4.
Member
|
I can never remember which commands expect full URLs and which expect page slugs. Yari ought to make some effort to validate and/or normalize this. |
Member
Author
Exactly this!! Plus |
teoli2003
approved these changes
Sep 1, 2022
goshdarnheck
pushed a commit
to goshdarnheck/content
that referenced
this pull request
Sep 7, 2022
* Redirect Document DnD events to HTMLElement * Revert "Redirect Document DnD events to HTMLElement" This reverts commit 5c655b4. * redo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@foolip said in mdn/browser-compat-data#16556 (review):
@queengooborg opened a content PR for
GlobalEventHandlerredirects: #18286 but no redirects fromDocumenttoHTMLElementhappened.Meanwhile the BCD already removed the compat data for
DocumentDnD events: mdn/browser-compat-data#16556. That's why these pages are now displayed without compat tables and spec sections.So, this PR removes and redirects
DocumentDnD events toHTMLELement.I hope this makes sense in light of the event pages reorg.