Adding compat data for Blob #988
Conversation
Elchi3
left a comment
There was a problem hiding this comment.
Not a big fan of these lengthy notes in the compat data. I think it would be OK to leave them out entirely as they are on the wiki page elsewhere, too. Thanks for you work!
api/Blob.json
Outdated
| }, | ||
| "chrome": { | ||
| "version_added": "5", | ||
| "notes": "A version of <code>slice()</code> taking the length as second argument was implemented in <a href='http://trac.webkit.org/changeset/55670'>WebKit</a> and <a href='http://www.opera.com/docs/specs/presto28/file/#blob'>Opera 11.10</a>. However, since that syntax differed from <a href='/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/slice'><code>Array.slice()</code></a> and <a href='/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/slice'><code>String.slice()</code></a>, WebKit removed support and added support for the new syntax as <a href='http://trac.webkit.org/changeset/83873'><code>Blob.webkitSlice()</code></a>." |
There was a problem hiding this comment.
Remove these notes. I don't think they belong here.
api/Blob.json
Outdated
| "safari": { | ||
| "version_added": "5.1", | ||
| "prefix": "webkit", | ||
| "notes": "This was implemented in <a href='http://trac.webkit.org/changeset/83873'>534.29</a>." |
There was a problem hiding this comment.
Remove this note. too. The bug that implemented something is not relevant to anyone anymore.
api/Blob.json
Outdated
| "version_added": "5", | ||
| "version_removed": "21", | ||
| "prefix": "webkit", | ||
| "notes": "The <code>slice()</code> method had initially taken <code>length</code> as the second argument to indicate the number of bytes to include in the new <code>Blob</code>. If you specified values such that <code>start + length</code> exceeded the size of the source <code>Blob</code>, the returned <code>Blob</code> contained data from the start index to the end of the source <code>Blob</code>. That version of the <code>slice()</code> was implemented in <a href='https://hg.mozilla.org/mozilla-central/rev/1b3947ed93c6'>Firefox 4</a>, <a href='http://trac.webkit.org/changeset/55670'>WebKit</a>, and <a href='http://www.opera.com/docs/specs/presto28/file/#blob'>Opera 11.10</a>. However, since that syntax is differed from <a href='/en-US/JavaScript/Reference/Global_Objects/Array/slice'><code>Array.slice()</code></a> and <a href='/en-US/JavaScript/Reference/Global_Objects/String/slice'><code>String.slice()</code></a>, Gecko and WebKit removed support and added support for the new syntax as <code>Blob.slice()</code>/<a href='http://trac.webkit.org/changeset/83873'><code>Blob.webkitSlice</code></a>." |
There was a problem hiding this comment.
Let's remove these lengthy notes here, too. They are way too long and we have the situation explained in the wiki at the top of the page already. The important (machine-readable) info here are the prefixes.
|
Alrighty, removed some of those redundant notes - there's a couple more that are a bit long, but they seem to be relevant to actual implementation-specific quirks, so I kept them in. Sorry about that! |
|
Thank you! |
|
Done! 😄 |
Hey there all! Just dropping this here 😄
Quick question about the notes in the first
Blobentry though - should those be retained? That information is essentially wholesale duplicated in the actual compat data forslice, so it seems a little redundant to restate.Fixes #969