Add compat data for RTCIceServer, RTCIdentity*, and RTCPeerConnection by bunnybooboo · Pull Request #987 · mdn/browser-compat-data

bunnybooboo · 2018-02-09T18:41:53Z

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer

was a little unsure if I should include the Constants category

bunnybooboo · 2018-02-09T22:14:41Z

Will be doing individual PR's from now as discussed w/ teoli.

bunnybooboo · 2018-02-09T22:28:38Z

https://developer.mozilla.org/en-US/docs/Web/API/RTCIdentityAssertion
https://developer.mozilla.org/en-US/docs/Web/API/RTCIdentityErrorEvent
https://developer.mozilla.org/en-US/docs/Web/API/RTCIdentityEvent
https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection

bunnybooboo · 2018-02-10T13:56:09Z

Performed a rebase -i to remove commits inherited from earlier branch. PR now reflects what is being actioned.

Elchi3 · 2018-02-13T18:45:34Z

api/RTCIceServer.json

+              "version_added": null
+            },
+            "firefox": {
+              "version_added": "22"


The page says Firefox 47, https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer/credentialType

Elchi3 · 2018-02-13T18:46:31Z

api/RTCIceServer.json

+              "version_added": null
+            },
+            "firefox": {
+              "version_added": "22"


The page says Firefox 37 https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer/urls

Elchi3 · 2018-02-13T18:49:16Z

api/RTCIceServer.json

+              "version_added": null
+            },
+            "firefox": {
+              "version_added": "22"


The page says Firefox 23, https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer/username

Elchi3 · 2018-02-13T19:00:57Z

api/RTCIdentityErrorEvent.json

+          },
+          "firefox": {
+            "alternative_name": "RTCPeerConnectionIdentityErrorEvent",
+            "version_added": null


Elchi3 · 2018-02-13T19:02:10Z

api/RTCIdentityErrorEvent.json

+              "version_added": null
+            },
+            "firefox": {
+              "alternative_name": "RTCPeerConnectionIdentityErrorEvent",


The alternative_name is not needed here again. idp has no alternate name, but the interface has one.

Elchi3 · 2018-02-13T19:02:27Z

api/RTCIdentityErrorEvent.json

+              "version_added": null
+            },
+            "firefox": {
+              "alternative_name": "RTCPeerConnectionIdentityErrorEvent",


Here neither, remove alternative_name.

Elchi3 · 2018-02-13T19:02:38Z

api/RTCIdentityErrorEvent.json

+              "version_added": null
+            },
+            "firefox": {
+              "alternative_name": "RTCPeerConnectionIdentityErrorEvent",


Remove alternative_name

Elchi3 · 2018-02-13T19:11:30Z

api/RTCIdentityEvent.json

+              "version_added": null
+            },
+            "firefox": {
+              "alternative_name": "RTCPeerConnectionIdentityEvent",


Remove alternative_name here

Elchi3 · 2018-02-13T19:16:21Z

api/RTCPeerConnection.json

+        "support": {
+          "webview_android": [
+            {
+              "notes": "<code>-webkit</code>",


This needs to use the "prefix" property:
https://github.com/mdn/browser-compat-data/blob/master/schemas/compat-data-schema.md#prefix
"prefix": "webkit" (no dash)

The prefix is not needed on the sub features of RTCPeerConnection.

If you could move the RTCPeerConnection.json file to a new separate PR, it would be better for reviewing maybe. It is quite giant.

Yes, apologies. On it.

jpmedley · 2018-02-14T02:14:51Z

api/RTCIdentityErrorEvent.json

+        "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIdentityErrorEvent",
+        "support": {
+          "webview_android": {
+            "version_added": null


Should be false.

jpmedley · 2018-02-14T02:15:10Z

api/RTCIdentityErrorEvent.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIdentityErrorEvent/idp",
+          "support": {
+            "webview_android": {
+              "version_added": null


jpmedley · 2018-02-14T02:15:26Z

api/RTCIdentityErrorEvent.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIdentityErrorEvent/loginUrl",
+          "support": {
+            "webview_android": {
+              "version_added": null


jpmedley · 2018-02-14T02:15:43Z

api/RTCIdentityErrorEvent.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIdentityErrorEvent/protocol",
+          "support": {
+            "webview_android": {
+              "version_added": null


jpmedley · 2018-02-14T02:16:41Z

api/RTCIdentityEvent.json

+        "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIdentityEvent",
+        "support": {
+          "webview_android": {
+            "version_added": null


Should be false.

jpmedley · 2018-02-14T02:16:57Z

api/RTCIdentityEvent.json

+            "version_added": false
+          },
+          "chrome_android": {
+            "version_added": null


jpmedley · 2018-02-14T02:17:13Z

api/RTCIdentityEvent.json

+          "mdn_url": "https://developer.mozilla.org/docs/Web/API/RTCIdentityEvent/assertion",
+          "support": {
+            "webview_android": {
+              "version_added": null


jpmedley · 2018-02-14T02:17:24Z

api/RTCIdentityEvent.json

+              "version_added": false
+            },
+            "chrome_android": {
+              "version_added": null


Elchi3

Excellent work. Thank you!

bunnybooboo changed the title ~~Add compat data for RTCIceServer~~ Add compat data for RTCIceServer and RTCIdentity* Feb 9, 2018

bunnybooboo changed the title Add compat data for RTCIceServer and RTCIdentity* Add compat data for RTCIceServer, RTCIdentity*, and RTCPeerConneection Feb 9, 2018

bunnybooboo changed the title ~~Add compat data for RTCIceServer, RTCIdentity*, and RTCPeerConneection~~ Add compat data for RTCIceServer, RTCIdentity*, and RTCPeerConnection Feb 9, 2018

teoli2003 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 10, 2018

bunnybooboo added 5 commits February 10, 2018 13:51

Add compat data for RTCIceServer

becf338

Add compat data RTCIdentityAssertion

82227c9

Add compat data RTCIdentityErrorEvent

ce1e9eb

Add compat data RTCIdentityEvent

edcf915

Add compat data RTCPeerConnection

a4a484b

bunnybooboo force-pushed the bcd-friday branch from 0e69c5e to a4a484b Compare February 10, 2018 13:51

Elchi3 requested changes Feb 13, 2018

View reviewed changes

bunnybooboo added 4 commits February 13, 2018 21:13

Edit Firefox versions

ae4fb05

Edit line 24 to true, remove alternative names

48bdb14

Remove alternative name

9836c23

Delete RTCPeerConnecttion.json

74a8930

bunnybooboo mentioned this pull request Feb 13, 2018

Add compat data for RTCPeerConnection #1070

Merged

jpmedley suggested changes Feb 14, 2018

View reviewed changes

bunnybooboo added 2 commits February 14, 2018 16:49

Edit webview_android to false

5de6fbb

Edit webview_android & chrome_android to false

c18d46b

jpmedley approved these changes Feb 14, 2018

View reviewed changes

Elchi3 approved these changes Feb 16, 2018

View reviewed changes

Elchi3 merged commit 2315add into mdn:master Feb 16, 2018

bunnybooboo deleted the bcd-friday branch February 16, 2018 10:09

dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018

Add compat data for RTCIceServer and RTCIdentity* (mdn#987)

fb1fd8f

foolip mentioned this pull request Jun 18, 2021

Remove RTCIdentityEvent and RTCIdentityErrorEvent #11149

Merged

Conversation

bunnybooboo commented Feb 9, 2018

Uh oh!

bunnybooboo commented Feb 9, 2018

Uh oh!

bunnybooboo commented Feb 9, 2018

Uh oh!

bunnybooboo commented Feb 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Elchi3 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bunnybooboo commented Feb 10, 2018 •

edited

Loading