Mark Request.p.formData partial in Safari#6616
Merged
Conversation
Per https://webkit.org/b/212858, Request.prototype.formData isn’t fully supported in Safari. So this change marks it with "partial_implementation": true and adds a note with a link to the relevant WebKit bug. Fixes #6520
foolip
approved these changes
Aug 31, 2020
Contributor
|
I came across https://bugs.webkit.org/show_bug.cgi?id=215671 just now, fixed very recently. |
Member
Author
Nice find. So after it’s clear that’s gone into a stable release (or will be), we can re-test and update the data here. |
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Aug 31, 2020
It's more useful to document this as no support, since it will always throw. This is a follow-up to mdn#6616.
This was referenced Aug 31, 2020
Contributor
|
I've filed #6620 to follow up on that. |
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Sep 2, 2020
Even though it doesn't work at all, it should be partial_implementation per https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#non-functional-defined-names-imply-partial_implementation This is a follow-up to mdn#6616.
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Sep 2, 2020
Even though it doesn't work at all, it should be partial_implementation per https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#non-functional-defined-names-imply-partial_implementation This is a follow-up to mdn#6616. Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
added a commit
that referenced
this pull request
Sep 2, 2020
Even though it doesn't work at all, it should be partial_implementation per https://github.com/mdn/browser-compat-data/blob/master/docs/data-guidelines.md#non-functional-defined-names-imply-partial_implementation This is a follow-up to #6616. Co-authored-by: Daniel D. Beck <daniel@ddbeck.com> Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per https://webkit.org/b/212858,
Request.prototype.formDataisn’t fully supported in Safari. So this change marks it with"partial_implementation": trueand adds a note with a link to the relevant WebKit bug.Fixes #6520