Remove x moz errormessage#3364
Remove x moz errormessage#3364Elchi3 merged 3 commits intomdn:masterfrom chrisdavidmills:remove-x-moz-errormessage
Conversation
|
There is also #3093 which adds a file for input attributes. |
|
Sure, I'm happy to wait for a discussion and decision on this. My addition is not exactly a critical piece of support info; just a nice to have really. My thinking was that we would have a separate file for "global" input attributes (e.g. available on all input types), and then add support info for attributes that are only supported on specific info types into the JSON files for those types. Of course, this doesn't mean we'd have to add explicit support info for all attributes; just ones that were added later and so don't fit the "Basic support" details. |
|
So the current approach for this is that described in #1698 (comment), and has us treating different types of input elements as different entities, from a BCD perspective. At the moment this gives us compat tables like: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color#Browser_compatibility The main reasons for this are:
Documenting compat for other attributes, even global ones, at the level of But that's just my opinion :). |
|
This all makes sense. So what should we do about global input attributes then? It sounds you are saying we'll have to duplicate the attribute support info across all the attributes. Which won't be any fun. |
|
The linked comment #1698 (comment) talks about this:
So that recommends that we should only list attributes, including global ones, when we have something interesting to say about them, and otherwise treat them we covered by the "Basic support" data for that input type. |
|
Just to correct my wording from before:
I meant "It sounds you are saying we'll have to duplicate the attribute support info across all the input types" To answer Will's followup comment:
OK, so in this case I believe we do have something interesting to say that isn't covered by Basic support. This still doesn't answer my question of where to put the data in such a case. |
|
This should probably be placed at the top level¹ into ¹ By that I mean |
|
That would probably work for me. I'll wait for a second opinion from Will/Florian. |
|
That works for me, too. The export "html.elements.input.x-moz-errormessage" is exactly what I would expect. |
|
I think input.json would be better, as this would allow the file to logically contain data points that aren't just covered by "Basic support", whether they concern attribute support or something else. I'm happy to change it. One more question is whether we should add "Basic support" info at the input level? I agree with Will's statement about people wanting information on radio buttons or checkboxes, not "the input element", but at the same time it feels weird that the input page's compat table doesn't have a Basic support line, whereas pretty much every other one does. |
|
Thanks @ExE-Boss ; I agree with this, and I think we should change the filename. I've done both. |
As per https://bugzilla.mozilla.org/show_bug.cgi?id=1513890
I added an extra file to contain compat data for global input element attributes, as we didn't have a specific file just for general input element attributes. Let me know what you think ;-)