Skip to content

Add more support information of input element#3093

Closed
SimonHeimberg wants to merge 3 commits intomdn:masterfrom
SimonHeimberg:moreCompatForHtmlElementInput
Closed

Add more support information of input element#3093
SimonHeimberg wants to merge 3 commits intomdn:masterfrom
SimonHeimberg:moreCompatForHtmlElementInput

Conversation

@SimonHeimberg
Copy link

start adding compatibility information in new format
from deleted old table in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input$revision/1435221

@SimonHeimberg
Copy link
Author

SimonHeimberg commented Nov 15, 2018

Before adding more data, I would like to get some feedback if I am doing this correctly:

* Is this the correct file?
* Will this information be combined with the existing table (with type support)?

More lines will be added.

Travis already shows me some errors. (I have problems with running npm locally, so I did not see this before. I always get a git timeout when running npm install.)

@SimonHeimberg SimonHeimberg force-pushed the moreCompatForHtmlElementInput branch from 1648682 to ec888e2 Compare November 15, 2018 11:52
@SimonHeimberg
Copy link
Author

SimonHeimberg commented Nov 15, 2018

travis is pleased now. Any human feedback to the questions above?

@Elchi3 Elchi3 added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Nov 16, 2018
@wbamberg wbamberg self-requested a review November 22, 2018 00:20
@SimonHeimberg SimonHeimberg force-pushed the moreCompatForHtmlElementInput branch from 0759ce4 to 7ca1b4b Compare November 29, 2018 23:26
@Elchi3 Elchi3 mentioned this pull request Feb 4, 2019
@wbamberg
Copy link
Contributor

wbamberg commented Feb 8, 2019

So sorry to take so long to comment on this. We had a conversation about how to model BCD for input elements a while ago, the main comment is here: #1698 (comment).

Essentially, the idea is to treat different input types more or less as if they were different elements, which seems to mesh better with how people treat them.

We would then not document attribute support at the input level, we'd document it at the level of the different types. (However we wouldn't document compat for the other attributes unless we need to (meaning, unless the compat story for the other attributes is different from the compat story for the type itself).)

At the moment this gives us compat tables like:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/color#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/range#Browser_compatibility
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#Browser_compatibility

...which seem quite usable to me.

I'm not against revisiting this choice if we think it's not working out well though.

@ddbeck
Copy link
Contributor

ddbeck commented Feb 25, 2019

Hi @SimonHeimberg, do you plan on responding or updating your PR based on the feedback from wbamberg?

@ddbeck
Copy link
Contributor

ddbeck commented Mar 11, 2019

Hi again, @SimonHeimberg. Thanks for your work on this. I'm assuming that you don't have time to get to this right now. I'm going to close this PR, but please feel free to reopen this in the future, if you get time to do so. Thanks again!

@ddbeck ddbeck closed this Mar 11, 2019
@Elchi3 Elchi3 removed the request for review from wbamberg August 14, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants