getPublicKey(): add per-algorithm subfeatures#29637
Merged
Merged
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
ddbeck
commented
May 8, 2026
587620a to
59939e6
Compare
caugner
approved these changes
May 12, 2026
caugner
approved these changes
May 15, 2026
Merged
ddbeck
added a commit
to ddbeck/web-features
that referenced
this pull request
May 19, 2026
ddbeck
added a commit
to web-platform-dx/web-features
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Break out algorithm support in
api.AuthenticatorAttestationResponse.getPublicKeyinto separate subfeatures.Test results and supporting details
This partially unwinds the change in #29458, which marked the whole method as partial.
While these algorithms are a "MUST" requirement in the specification text, this behavior has been missing from Safari from its inception in 2022 but only reported as a bug a few weeks ago.
This is unlikely to meet our partial guideline. Specifically, the long interval between implementation and bug report suggests that this does not yet have "a demonstrable negative impact on web developers." And although the spec says that these algorithms are strictly required, it's not really creating "confusing feature detection results" when the spec otherwise requires the method to return
nullfor unsupported key formats (others not specifically called for by the "MUST" requirement).Breaking the feature up seems like a good compromise between adherence to the specification text and reflecting the real-world practicalities.
To help name these subfeatures, I referred to the specification text and the IANA algorithm name and description tables.
Related issues
AuthenticatorAttestationResponse.getPublicKey()#29458webauthn-public-key-easyto regress to limited availability web-platform-dx/web-features#3995webauthn-public-key-easy: pin status to common algorithm web-platform-dx/web-features#4020