Skip to content

Add compat data to api.MouseEvent#1883

Merged
Elchi3 merged 3 commits intomdn:masterfrom
luciancic:api/MouseEvent
May 30, 2018
Merged

Add compat data to api.MouseEvent#1883
Elchi3 merged 3 commits intomdn:masterfrom
luciancic:api/MouseEvent

Conversation

@luciancic
Copy link

@luciancic luciancic commented Apr 21, 2018

MouseEvent
The tables are missing quite a bit of data so I used my best judgement to make what was available somewhat consistent.
One question: how can I add the notes from buttons for Firefox? Do I add the huge paragraph in a note?

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 23, 2018
},
"chrome_android": {
"version_added": null
"version_added": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MDN table has it listed as false for Chrome for Android, I'm not sure what mouse support is like for android browsers? Ditto for Webview Android.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked it as true because I was thinking something like: "How can basic support be false when sub-feature support is true?"
Waiting on additional input for how to proceed.

"version_added": "47"
},
"chrome": {
"version_added": "47"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the MDN page says the constructor got support in Chrome in v45

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the root page indicated v45. However, the constructor page said otherwise. When in doubt, I use the later version.

"deprecated": false
}
},
"long_to_double": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MDN table only mentions MouseEvent.screenX, MouseEvent.screenY, MouseEvent.clientX, and MouseEvent.Y [sic] as being converted from a long to a double. Nothing about offset as far as I can tell.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a note about it.

}
}
},
"x": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the MDN page, x and y are just aliases of clientX and clientY. Should these be merged into clientX/clientY as alternative names? I'm not sure how this should work.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll take a look.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should stay separate for now because x and y are still experimental and there is no way to show that fact on the alternative name of a non-experimental sub-feature, as far as I know.

"deprecated": false
}
},
"accel_support": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interestingly, Accel is said to have been "effectively deprecated" for the KeyboardEvent API, I wonder if the same is true of MouseEvent? And if we should handle this in some way? https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/getModifierState#Accel_virtual_modifier

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that way. I found no mention of "Accel" in the newer ui events spec for neither KeyboardEvent nor MouseEvent. Good catch!

@Elchi3 Elchi3 added this to the Q2 Sprint 3 milestone May 13, 2018
@Elchi3
Copy link
Member

Elchi3 commented May 30, 2018

One question: how can I add the notes from buttons for Firefox? Do I add the huge paragraph in a note?

The way you've done this here is better in my opinion. I'd like to have giant texts and notes to remain in the wiki. 👍

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work, thank you @lucian95 👍

@Elchi3 Elchi3 merged commit 9de45b8 into mdn:master May 30, 2018
@luciancic luciancic deleted the api/MouseEvent branch May 30, 2018 21:20
a2sheppy pushed a commit to a2sheppy/browser-compat-data that referenced this pull request Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants