Limit main eight browsers to real values for api/#13845
Merged
Conversation
foolip
approved these changes
Dec 3, 2021
Elchi3
approved these changes
Dec 4, 2021
Member
Elchi3
left a comment
There was a problem hiding this comment.
LGTM!
Wondering if open PRs would fail main if they aren't rebased prior merging. https://github.com/mdn/browser-compat-data/pulls?page=2&q=is%3Apr+is%3Aopen+label%3A%22data%3Aapi+%3Arabbit2%3A%22 is the open list of PRs for data:api and I guess a few are adding new features where support is sometimes a non-real value. Thoughts?
Contributor
Author
|
For those adding new features containing nonreal values, we should label them as "rebase needed" and work to remove the nonreal values before merging them, yeah! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We finally did it! We reached 100% real+ranged values for the main eight browsers for the API data!
This PR prevents us from regressing and adding true/null values. Closes #6369.