Remove api.XMLHttpRequest.readyState.constants from BCD#12879
Merged
Remove api.XMLHttpRequest.readyState.constants from BCD#12879
Conversation
This PR removes the `readyState.constants` member of the `XMLHttpRequest` API from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.
Contributor
|
@queengooborg there's a conflict to resolve here. |
Contributor
Author
|
Realizing we don't need to make any content updates for this removal! |
foolip
approved these changes
Nov 12, 2021
Contributor
I saw about to merge when I noticed this description isn't right. The reason this should be removed is https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#constants. |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data about constants should not be included BCD:
https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#constants