Skip to content

Remove VRLayerInit API from BCD#12818

Merged
foolip merged 1 commit intomdn:mainfrom
queengooborg:api/VRLayerInit/removal
Oct 18, 2021
Merged

Remove VRLayerInit API from BCD#12818
foolip merged 1 commit intomdn:mainfrom
queengooborg:api/VRLayerInit/removal

Conversation

@queengooborg
Copy link
Contributor

This PR removes VRLayerInit from BCD. This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.

This PR removes `VRLayerInit` from BCD.  This feature is a dictionary, enum, or WebIDL typedef and should not be included in BCD.
@queengooborg queengooborg added needs-release-note 📰 needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Oct 12, 2021
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 12, 2021
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 12, 2021
@foolip foolip merged commit 453f045 into mdn:main Oct 18, 2021
@queengooborg queengooborg deleted the api/VRLayerInit/removal branch October 18, 2021 19:59
@ddbeck ddbeck added needs content update This PR needs a corresponding update to mdn/content to update the documentation and removed needs-release-note 📰 labels Oct 19, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 19, 2021
@ddbeck
Copy link
Contributor

ddbeck commented Oct 19, 2021

This is another one where I'm confused by the content PR. We didn't remove it, we just broke the connection to BCD. This feels like a bit of a dodge and I don't know how this approach came about. 😕

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 19, 2021
ddbeck added a commit that referenced this pull request Oct 19, 2021
* Bump version to v4.0.7

* Set release date

* Add release note for #12824

* Add release note for #11909

* Add release note for #12818

* Add release note for #12832

* Add release note for #12836

* Hoist known issues

* Add stats

* Add link to new data guideline
@queengooborg
Copy link
Contributor Author

The reasoning for a simple unlink, rather than a removal from MDN like usual, is primarily due to the number of methods that utilize it -- or more specifically, the way it's referenced throughout various documents. It didn't feel like the right move to remove the pages and rewrite some of these articles, especially as we'll probably end up removing WebVR's documentation in the future (since it's getting replaced by WebXR).

@ddbeck
Copy link
Contributor

ddbeck commented Oct 20, 2021

Fair enough, but was there any discussion about this approach? I'm surprised that the content PRs for this and #12766 were merged without discussion. I feel like there's a lot going on implicitly and I'd like to know where to refer to should questions arise (i.e., what do I say if someone tries to re-create the BCD for these pages?).

@queengooborg
Copy link
Contributor Author

There was some discussion when I had initially attempted to remove CryptoKeyPair from MDN web docs: mdn/content#8846

@ddbeck ddbeck removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants