Add compat data for Console #1145
Conversation
Elchi3
left a comment
There was a problem hiding this comment.
Well done! I few structural changes, but otherwise this looks good to me! Thank you very much for contributing to mdn-browser-compat-data!
api/Console.json
Outdated
| "firefox": { | ||
| "version_added": "28", | ||
| "notes": [ | ||
| "Available in workers from 38 onwards" |
There was a problem hiding this comment.
Lets please remove the notes throughout the file and add worker support as a sub feature of console like so:
"worker_support": {
"__compat": {
"description": "Available in workers",
"support": {In the tree this would get added here:
- api
- Console
- __compat
- worker_support
- assert
- ...
- Console
api/Console.json
Outdated
| "chrome": { | ||
| "version_added": true, | ||
| "notes": [ | ||
| "Alias (console.exception) not available" |
There was a problem hiding this comment.
Please add exception as a separate subfeature (an own entry like error). And remove these notes throughout.
api/Console.json
Outdated
| "firefox": { | ||
| "version_added": "4", | ||
| "notes": [ | ||
| "Substitution strings available from 9 onwards", |
There was a problem hiding this comment.
Please add substitution strings as a separate sub feature here:
"substitution_strings": {
"__compat": {
"description": "Substitution strings",
"support": {In the tree this would get added here:
- api
- Console
- __compat
- error
- __compat
- substitution_strings
- info
- __compat
- substitution_strings
- ...
- Console
api/Console.json
Outdated
| "firefox": { | ||
| "version_added": "9", | ||
| "notes": [ | ||
| "This method is supported starting in Gecko 9 (Firefox 9 / Thunderbird 9 / SeaMonkey 2.6), but the new group was not collapsed; it's functionally was equivalent to console.group(). Since Gecko 52.0 (Firefox 52.0 / Thunderbird 52.0 / SeaMonkey 2.49) the group is collapsed", |
There was a problem hiding this comment.
So basically it works starting with 52. Lets remove this note and add version_added: 52.
api/Console.json
Outdated
| "firefox_android": { | ||
| "version_added": "9", | ||
| "notes": [ | ||
| "This method is supported starting in Gecko 9 (Firefox 9 / Thunderbird 9 / SeaMonkey 2.6), but the new group was not collapsed; it's functionally was equivalent to console.group(). Since Gecko 52.0 (Firefox 52.0 / Thunderbird 52.0 / SeaMonkey 2.49) the group is collapsed", |
api/Console.json
Outdated
| "version_added": "4", | ||
| "notes": [ | ||
| "Available in workers from 38 onwards", | ||
| "Subtitution string available from 9 onwards" |
There was a problem hiding this comment.
Same thing for the substitution strings here. Please add a sub feature
api/Console.json
Outdated
| "chrome": { | ||
| "version_added": true, | ||
| "notes": [ | ||
| "Substitution strings available from 28 onwards", |
There was a problem hiding this comment.
Same thing for the substitution strings here. Please add a sub feature and add the second note there.
api/Console.json
Outdated
| "firefox": { | ||
| "version_added": "4", | ||
| "notes": [ | ||
| "Substitution strings available from 9 onwards", |
There was a problem hiding this comment.
Same thing for the substitution strings here. Please add a sub feature.
|
Hey there @Elchi3 - I've pushed a commit with the changes you requested. If there's anything else I've missed out, do let me know! |
Elchi3
left a comment
There was a problem hiding this comment.
Excellent work, thanks again! 👍
Adding compat data for the Console API (https://developer.mozilla.org/docs/Web/API/Console)