Add PerformanceResourceTiming #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmedley
suggested changes
Feb 16, 2018
api/PerformanceResourceTiming.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/PerformanceResourceTiming/workerStart", | ||
| "support": { | ||
| "webview_android": { | ||
| "version_added": "4.4" |
Contributor
There was a problem hiding this comment.
Please change to 43. Android webview follows Chrome numbering, not Android numbering.
Contributor
Author
There was a problem hiding this comment.
That’s what is written on the MDN page, I just copied the data to the new format.
Contributor
There was a problem hiding this comment.
The MDN page is wrong. Refer to the Chrome Platform Status to see how Chrome itself numbers things.
d9a2c50 to
93e7076
Compare
Elchi3
requested changes
Feb 26, 2018
Member
Elchi3
left a comment
There was a problem hiding this comment.
Thanks, nice work!
Two things and this should be good to go:
- https://developer.mozilla.org/en-US/docs/Web/API/PerformanceResourceTiming/connectStart is missing here
- @chrisdavidmills added "available in workers" just recently. please add that as a sub feature below PerformanceResourceTiming like so:
"worker_support": {
"__compat": {
"description": "Available in workers",
"support": {a6963c3 to
1b0c49d
Compare
dontcallmedom
pushed a commit
to dontcallmedom/browser-compat-data
that referenced
this pull request
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the browser compatibility table data for the
PerformanceResourceTimingAPI.I chose to do this one because the table being inaccurate caused us some issues when I helped Cloudflare with porting their Claire extension to Firefox (see cloudflare/claire#49 (comment)).