Skip to content

Update parameter entries to match guidelines#11080

Merged
ddbeck merged 2 commits intomdn:mainfrom
foolip:parameter-entries
Jun 18, 2021
Merged

Update parameter entries to match guidelines#11080
ddbeck merged 2 commits intomdn:mainfrom
foolip:parameter-entries

Conversation

@foolip
Copy link
Contributor

@foolip foolip commented Jun 17, 2021

@foolip foolip requested a review from ddbeck June 17, 2021 08:43
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 17, 2021
@queengooborg queengooborg added needs content update This PR needs a corresponding update to mdn/content to update the documentation needs-release-note 📰 labels Jun 17, 2021
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I checked the content and there was only one change needed (which I took care of, see line comments for details). I also spotted one rename that might not be necessary.

}
},
"deep_optional": {
"deep_parameter_optional": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all but certain this is an irrelevant feature. My impression is that deep was required when it was first introduced, but isn't now. I guess it's possible that EdgeHTML required, but I doubt it, given how thin this data is anyway. I'd rather see this one go away entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert this change and send a separate PR. Since the Firefox versions are set this smells a lot like a "we changed something and should document it" entry that stops being useful very soon after the Firefox release.

@foolip foolip requested a review from ddbeck June 18, 2021 14:56
@ddbeck ddbeck removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 18, 2021
Copy link
Contributor

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit d11d917 into mdn:main Jun 18, 2021
@foolip foolip deleted the parameter-entries branch June 18, 2021 15:13
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 18, 2021
ddbeck added a commit that referenced this pull request Jun 24, 2021
* Bump version to v3.3.9

* Add release note for #11080

* Add release note for #10774

* Add release note for #11149

* Add release note for #11174

* Add release note for #11229

* Add release note for #10700

* Add stats and release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants