adding compat data for HTML global attributes #1089
Conversation
|
Hey, thanks for your pull request! 💯 If you want to validate the JSON locally, you can also do so using |
|
OK, got it. I get the same error: This is due to the file format being html.global_attributes having all attributes listed below. |
| "chrome": { | ||
| "version_added": true, | ||
| "version_removed": "52" | ||
| }, |
There was a problem hiding this comment.
chrome_android and webview_android should match this.
html/global_attributes.json
Outdated
| "version_added": true | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "64", |
There was a problem hiding this comment.
This is 47, not 64.
html/global_attributes.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Global_attributes/spellcheck", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": true |
There was a problem hiding this comment.
This should be 9.
html/global_attributes.json
Outdated
| "partial_implementation": false | ||
| }, | ||
| "webview_android": { | ||
| "version_added": "4.4", |
There was a problem hiding this comment.
This should be 47. Webview version numbers follow Chromium, not Android.
html/global_attributes.json
Outdated
| } | ||
| } | ||
| }, | ||
| "data-*": { |
There was a problem hiding this comment.
This is not a valid identifier unfortunately. (the error message is not helpful, so you couldn't know this.
"data-*": {
Better would be:
"data_attributes": {
"__compat": {
"description": "<code>data-*</code> attributes",
"mdn_url": "...",
"support": {
Elchi3
left a comment
There was a problem hiding this comment.
Thanks so much for your work! I've fixed up the minor issues for you. Let's merge this! 🎉
…support This PR updates and corrects version values for all browsers for the `title.multi-line-support` member of the `global_attributes` HTML feature. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD. Commit/PR Adding the Feature: mdn#1089
…support (#23424) This PR updates and corrects version values for all browsers for the `title.multi-line-support` member of the `global_attributes` HTML feature. This sets the feature(s) to a version range based upon the date that the feature was added to BCD with the intent of replacing `true` values with ranged values to eliminate `true` values from BCD. Commit/PR Adding the Feature: #1089
#914