Update data for paymentmethodchange event#10622
Merged
Conversation
Copied from onpaymentmethodchange. I think there should be a linter for this 🤔
saschanaz
added a commit
to saschanaz/browser-compat-data
that referenced
this pull request
May 24, 2021
Contributor
Yeah, there's a lot of obviously wrong data that could be caught be something pretty simple here. The trouble is there's no hard rule, neither kind of entry implies the other. See #7545. Some kind of grouping concept would be useful I think, where the expectation is that data should match but there's a way to make it not match if that's really what happened. |
foolip
approved these changes
May 31, 2021
Contributor
foolip
left a comment
There was a problem hiding this comment.
Running mdn-bcd-collector doesn't update the onpaymentmethodchange entry this is based on, so it's probably mostly right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from onpaymentmethodchange.
I think there should be a linter for this 🤔
Summary
A simple data copy.
Test results and supporting details
Related issues