Skip to content

Conversation

@germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Feb 11, 2018

Fixes #971

It's my first contribution to this compat data repo. Let me know if I missed anything.
There were a few missing browsers on the documentation itself. Not sure what the process is in that case?

Also edited the https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/Compatibility_tables documentation for some dead link to the advanced schema MD file.

@germain-gg germain-gg changed the title adding compata data for BroadcastChannel #971 adding compata data for BroadcastChannel Feb 11, 2018
@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 12, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change and this is good to go. Thank you!

},
"BroadcastChannel": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/BroadcastChannel/BroadcastChannel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description here: "description": "<code>BroadcastChannel()</code> constructor", (it might not be that obvious what a constructor is from looking at the data structure and this way the table should look like here: https://developer.mozilla.org//en-US/docs/Web/API/AbortController#Browser_compatibility)

See also https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/Compatibility_tables#Adding_a_description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍
Thanks for the review

@Elchi3
Copy link
Member

Elchi3 commented Feb 12, 2018

There were a few missing browsers on the documentation itself. Not sure what the process is in that case?

For the moment, we're mainly focusing on migrating the data we have on MDN into this repository. We're planning to concentrate on improving, completing and verifying the data in a later phase, though.

Also edited the https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/Compatibility_tables documentation for some dead link to the advanced schema MD file.

Thank you! This helps everyone, very much appreciated!

@teoli2003 teoli2003 changed the title adding compata data for BroadcastChannel Add comp data for BroadcastChannel Feb 12, 2018
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Elchi3 Elchi3 merged commit f485f89 into mdn:master Feb 13, 2018
dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants