-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Add comp data for BroadcastChannel #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor change and this is good to go. Thank you!
| }, | ||
| "BroadcastChannel": { | ||
| "__compat": { | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/BroadcastChannel/BroadcastChannel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description here: "description": "<code>BroadcastChannel()</code> constructor", (it might not be that obvious what a constructor is from looking at the data structure and this way the table should look like here: https://developer.mozilla.org//en-US/docs/Web/API/AbortController#Browser_compatibility)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed 👍
Thanks for the review
For the moment, we're mainly focusing on migrating the data we have on MDN into this repository. We're planning to concentrate on improving, completing and verifying the data in a later phase, though.
Thank you! This helps everyone, very much appreciated! |
Elchi3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #971
It's my first contribution to this compat data repo. Let me know if I missed anything.
There were a few missing browsers on the documentation itself. Not sure what the process is in that case?
Also edited the https://developer.mozilla.org/en-US/docs/MDN/Contribute/Structures/Compatibility_tables documentation for some dead link to the advanced schema MD file.