Skip to content

Conversation

@bennypowers
Copy link
Contributor

@bennypowers bennypowers commented Feb 11, 2018

No description provided.

@teoli2003 teoli2003 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 11, 2018
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost! The URL is incorrect, but we are close to land this. Well done and thank you a lot.

"api": {
"AnimationEffectTimingReadOnly": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/AnimationEffectTiming",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3
Copy link
Member

Elchi3 commented Feb 12, 2018

This interface has a few properties:
delay
direction
duration
easing
endDelay
fill
iterations
iterationStart

Would you mind adding these as sub features here, too?

@bennypowers
Copy link
Contributor Author

@Elchi3 should that be in a separate PR?

@Elchi3
Copy link
Member

Elchi3 commented Feb 12, 2018

@bennypowers If you like, you could also do that right here.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Elchi3 Elchi3 dismissed teoli2003’s stale review February 13, 2018 20:04

comment addressed

@Elchi3 Elchi3 merged commit 49e2526 into mdn:master Feb 13, 2018
dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants