Adds compat data for AnimationEffectTiming #1000
Conversation
74fab7f to
bc58235
Compare
teoli2003
left a comment
There was a problem hiding this comment.
Hi, Benny!
This is really good, you didn't hear about the "flags" directive, so I linked to its docs where you need to use it. But besides of this, it is overall really good! Almost ready to land.
api/AnimationEffectTiming.json
Outdated
| }, | ||
| "firefox": { | ||
| "version_added": "48", | ||
| "notes": "The Web Animations API is only enabled by default in Firefox Developer Edition and Nightly builds. You can enable it in beta and release builds by setting the preference <code>dom.animations-api.core.enabled</code> to <code>true</code>, and can disable it in any Firefox version by setting this preference to <code>false</code>." |
There was a problem hiding this comment.
We use the "flags" directive to indicate that support (in release) is behind a flag. See the docs for more info and an example of use.
In this case, we also have to reformulate the note to say that the preference is on by default in Firefox Developer Edition and Nightly builds.
api/AnimationEffectTiming.json
Outdated
| }, | ||
| "firefox_android": { | ||
| "version_added": "48", | ||
| "notes": "The Web Animations API is only enabled by default in Firefox Developer Edition and Nightly builds. You can enable it in beta and release builds by setting the preference <code>dom.animations-api.core.enabled</code> to <code>true</code>, and can disable it in any Firefox version by setting this preference to <code>false</code>." |
There was a problem hiding this comment.
We use the "flags" directive to indicate that support (in release) is behind a flag. See the docs for more info and an example of use.
In this case, we also have to reformulate the note to say that the preference is on by default in Firefox Developer Edition and Nightly builds.
There was a problem hiding this comment.
Please see latest diff
|
I'm unclear as to the correct wording for the note, assuming there's also a flags directive. Can you link to an example? |
|
Sure, here is the docs with an example: https://github.com/mdn/browser-compat-data/blob/master/schemas/compat-data-schema.md#flags the "notes" could be something like: "The preference is set to <code>true</code> by default on Firefox Nightly and on Firefox Developer Edition, but not on the official release." |
No description provided.