Don't crash if Share comms are in progress when initialized#2
Merged
Conversation
erikdi
pushed a commit
to erikdi/G4ShareSpy
that referenced
this pull request
Apr 15, 2020
* Avoid carthage build when using workspace setup * Modal presentation of CGMManager settings. * Don't push root viewcontroller * update to pumpmanager-updates * Setup controller is shown modally * Update to dev version of LoopKit
erikdi
pushed a commit
to erikdi/G4ShareSpy
that referenced
this pull request
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event that
Receiveris initialized when the Share app is communicating with the receiver, and the receiver is in the middle of sending a message, and one chunk of the message is less than 4 bytes, there will be a crash. This fixes it.Also: stop surfacing
BadCRCandUnexpectedByteserrors, as they occur only in this case, and are not truly errors.didErrornow reports only real errors (fromBluetoothManager).