Closed
Conversation
This was referenced May 14, 2022
mccoyp
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Adding in some functionality to use different clouds This support is needed for the air gapped environments. There are three ways to add a new cloud environment. These were all taken from examples in the v1 sdk. 1) The SDK will look for a default configuration file and try to find cloud environments in there. 2) If you set an environment variable called ARM_METADATA_URL, it will look there for cloud configurations. If you do not set this, it will use a default URL in the _azure_environments.py file to find them. 3) The SDK exposes two new functions, add_cloud which will add the new configuration to the configuration file mentioned in #1, and update_cloud which will update the added configuration. * Removing some of the functionality, only ARM check remains * Adding unit test for new environments functionality * fixed tests with mock * removed print statement * removed commented code * removed print statements (oops) * fixed tests and removed comments * Fixing a testing bug * Fixing a misspelled word * Changing how we reach out to ARM, als fixing some pylint * Fixing more lint errors * Fixing more lint errors * updated code per suggestions in PR * fixed typo in warning * added registry_endpoint to metadata url, also added tests for making sure all endpointurls are registered * updated how the registry discovery endpoint is created. Uses a default region but region can be updated with environment variable * fixed linting errors * moved discovery url logic around to make sure it's not overwriting public regions * Fixing small pylint errors * Moving over to using HttpPipeline instead of requests * fixed up based on comments in the PR * fixed broken unit tests and mocked correctly * Fixing pylint issues --------- Co-authored-by: Ronald Shaw <ronaldshaw@microsoft.com>
|
Hi @mccoyp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
mccoyp
pushed a commit
that referenced
this pull request
Jul 27, 2023
* Update with new swagger * changes for job matching modes * remove generated models - all models have been handcoded * fix lint errors #1 * fix lint errors 2 * update swagger to point to main specs repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype of how Key Vault could incorporate a multitenant auth-supporting authentication policy in Core, as proposed in Azure#24019.