Memory leak and exception safety in SVMlight reader#7
Merged
mblondel merged 2 commits intomblondel:svmlight_formatfrom Jun 13, 2011
Merged
Memory leak and exception safety in SVMlight reader#7mblondel merged 2 commits intomblondel:svmlight_formatfrom
mblondel merged 2 commits intomblondel:svmlight_formatfrom
Conversation
Also some minor refactoring
mblondel
added a commit
that referenced
this pull request
Jun 13, 2011
Memory leak and exception safety in SVMlight reader
mblondel
pushed a commit
that referenced
this pull request
Jul 17, 2013
WMinkowskiDistance corrections to error messages and docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was one guaranteed memory leak left because
tp_freewasn't called, and a potential one due to exception handling in what is now theto_csrfunction. I hope the module is now completely safe.