SVMlight reader update#6
Merged
mblondel merged 6 commits intomblondel:svmlight_formatfrom Jun 11, 2011
Merged
Conversation
Quick fix, maybe only partial: the deallocator seems not to be called in unit testing.
Uses placement new and vector::swap to eliminate some memory allocations. Main benefits: exception safety will be easier to guarantee and there are fewer opportunities for memory leaks. Still, this is a hairy beast. Also some other safety improvements.
Info from exceptions should be propagated up to the Python level, but currently isn't.
mblondel
pushed a commit
that referenced
this pull request
Aug 14, 2013
nitpick fixes, pep8 and fix math equations
mblondel
pushed a commit
that referenced
this pull request
Jan 16, 2014
Revised text classification chapter
mblondel
pushed a commit
that referenced
this pull request
Jan 16, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a version with lots and lots of new goodies including comments and internal exception handling. Next up is propagating the exceptions to the Python level.