Return success code when nothing to commit#9
Conversation
|
(sorry for the revert, I erronously included the commit from PR #8 - the revert is to fix that) |
|
Uh I'm a little confused about this, so correct me if I have this all wrong @leny. I see two separate issues here: 1. The current action appears to error out when there is nothing to commit. This does not, on the face of it, make much sense.
This, again, in some scenarios isn't what users might want or expect. Also, I think this problem should only occur in the first place for deploys from 2. If deploying from
|
|
Sorry this got more complicated than expected. So my (preliminary) suggestion would be to just @leny Does that make sense? Does that meet user expectations and keep things simple to reason about? Set me straight if I got this wrong. |
|
The more I think of it, the more I think the |
|
perfect, will merge, test and ship this then. |
Here's an implementation for the issue addressed in issue #7
The process return a
neutralwhen there's nothing to commit, instead of an error.