packages/html/stories/CustomHandlesConfiguration.stories.ts (2)

61-65: Avoid unintended whitespace in template literals

The indentation within the template literal for divMessage.innerHTML may introduce unwanted whitespaces or line breaks in the rendered HTML. Consider adjusting the template literal to prevent this issue.

Apply this diff to fix the issue:

-      divMessage.innerHTML = `To add a new edge bend, shift-click on the edge where you wish to add it.
-      <br>
-        To remove an existing edge bend, shift-click on it.
-      `;
+      divMessage.innerHTML = `To add a new edge bend, shift-click on the edge where you wish to add it.<br>To remove an existing edge bend, shift-click on it.`;

---

77-85: Consider resetting global configurations after the story

Modifying EdgeHandlerConfig directly within the Template function affects global settings and may impact other stories or components. To prevent unintended side effects, consider resetting the configurations after the story renders.

Apply this diff to reset the configurations:

+  import { resetEdgeHandlerConfig } from '@maxgraph/core';

  // Toggle custom handle defaults with storybook args
  if (args.customHandleDefaults) {
    // Existing configuration changes
  }

  // General configuration
  VertexHandlerConfig.rotationEnabled = true;

  // ... rest of the code ...

  return div;
+  
+  // Reset configurations after use
+  resetEdgeHandlerConfig();

packages/website/docs/usage/migrate-from-mxgraph.md (1)

439-452: Fix grammar and improve formatting.

The Cell handlers section needs minor improvements:

1. Grammar: Add missing article in line 448: "configured with a global configuration object"
2. Formatting: Consider adding code examples to demonstrate the before/after configuration changes

Apply this diff to fix the grammar:

-In `maxGraph`, the handlers are configured with global configuration object.
+In `maxGraph`, the handlers are configured with a global configuration object.

Would you like me to generate code examples showing the before/after configuration changes for better clarity?

🧰 Tools

🪛 LanguageTool

[grammar] ~442-~442: This phrase is duplicated. You should probably use “to to” only once.
Context: ...enamed in maxGraph: - mxEdgeHandler to EdgeHandler - mxEdgeSegmentHandler to EdgeSegmentHandler - mxElbowEdgeHandler to ElbowEdgeHandler - mxVertexHandler to VertexHandler In mxGraph, the hand...

(PHRASE_REPETITION)

---

[uncategorized] ~448-~448: Possible missing article found.
Context: ...raph`, the handlers are configured with global configuration object. For more details,...

(AI_HYDRA_LEO_MISSING_A)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/website/docs/usage/migrate-from-mxgraph.md (4)

447-449: Add a code example to illustrate the configuration changes.

While the explanation is clear, adding a before/after code example would make it easier for users to understand how to migrate their handler configurations from prototype-based to the new global configuration approach.

Consider adding an example like this:

- // Before in mxGraph
- mxEdgeHandler.prototype.addEnabled = true;
- mxEdgeHandler.prototype.removeEnabled = true;
+ // Now in maxGraph
+ EdgeHandlerConfig.addBendOnShiftClickEnabled = true;
+ EdgeHandlerConfig.removeBendOnShiftClickEnabled = true;

---

439-440: Add cross-references to related sections.

Consider adding references to related sections that might be relevant for handler configuration, such as the "Global Configuration" section mentioned later and any sections about event handling that might affect handlers.

---

442-445: Fix formatting in the class renaming list.

The list of renamed classes has a minor formatting issue. Each item should end with a period for consistency with other similar lists in the document.

Apply this change:

- - `mxEdgeHandler` to `EdgeHandler`
- - `mxEdgeSegmentHandler` to `EdgeSegmentHandler`
- - `mxElbowEdgeHandler` to `ElbowEdgeHandler`
- - `mxVertexHandler` to `VertexHandler`
+ - `mxEdgeHandler` to `EdgeHandler`.
+ - `mxEdgeSegmentHandler` to `EdgeSegmentHandler`.
+ - `mxElbowEdgeHandler` to `ElbowEdgeHandler`.
+ - `mxVertexHandler` to `VertexHandler`.

🧰 Tools

🪛 LanguageTool

[grammar] ~442-~442: This phrase is duplicated. You should probably use “to to” only once.
Context: ...enamed in maxGraph: - mxEdgeHandler to EdgeHandler - mxEdgeSegmentHandler to EdgeSegmentHandler - mxElbowEdgeHandler to ElbowEdgeHandler - mxVertexHandler to VertexHandler In mxGraph, the hand...

(PHRASE_REPETITION)

---

450-452: Add more context about the impact of property removals.

When mentioning the removal of properties like rotationEnabled, it would be helpful to explain the benefits of moving to the new configuration approach and any potential gotchas during migration.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

CHANGELOG.md (3)

13-14: Enhance the explanation of the breaking change.

The current explanation "not possible to correctly change their value" is vague. Consider providing more context about why these properties couldn't be changed correctly and the benefits of moving to global configuration.

-Some properties have been removed from `EdgeHandler` as it was not possible to correctly change their value.
+Some properties have been removed from `EdgeHandler` and moved to global configuration in `EdgeHandlerConfig` to ensure consistent edge handling behavior across the application. This change addresses issues where modifying these properties at runtime did not properly update the edge handling behavior.

---

15-18: Standardize the property mapping format and provide missing replacements.

1. The arrow format (-->) is inconsistent with other breaking changes in the changelog.
2. virtualBendOpacity and virtualBendsEnabled are missing their replacement property names.

-  - addEnabled --> addBendOnShiftClickEnabled
-  - removeEnabled --> removeBendOnShiftClickEnabled
-  - virtualBendOpacity
-  - virtualBendsEnabled
+  - `addEnabled` is replaced by `EdgeHandlerConfig.addBendOnShiftClickEnabled`
+  - `removeEnabled` is replaced by `EdgeHandlerConfig.removeBendOnShiftClickEnabled`
+  - `virtualBendOpacity` is replaced by `EdgeHandlerConfig.bendOpacity`
+  - `virtualBendsEnabled` is replaced by `EdgeHandlerConfig.bendsEnabled`

---

19-20: Add a code example for migration.

Following the pattern of other breaking changes in the changelog, consider adding a code example to help users migrate from the old properties to the new configuration.

   - virtualBendsEnabled

+Example of migrating from the old properties to the new configuration:
+```js
+// Old usage
+edgeHandler.addEnabled = true;
+edgeHandler.removeEnabled = true;
+edgeHandler.virtualBendOpacity = 0.5;
+edgeHandler.virtualBendsEnabled = true;
+
+// New usage
+EdgeHandlerConfig.addBendOnShiftClickEnabled = true;
+EdgeHandlerConfig.removeBendOnShiftClickEnabled = true;
+EdgeHandlerConfig.bendOpacity = 0.5;
+EdgeHandlerConfig.bendsEnabled = true;
+```

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro