Skip to content

fix(VertexHandler): do not create label handle for swimlane #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tbouffard merged 1 commit into from
Dec 31, 2024
Merged

fix(VertexHandler): do not create label handle for swimlane #607

tbouffard merged 1 commit into from
Dec 31, 2024

Conversation

@tbouffard
Copy link
Member

@tbouffard tbouffard commented Dec 30, 2024 •
edited by coderabbitai bot
Loading

This was in place in mxGraph and had been disabled for unknown reasons during the migration.

Summary by CodeRabbit

  • Bug Fixes
    • Updated handling of label shape for swimlane cells, improving visual interaction and usability.

@tbouffard
fix(VertexHandler): do not create label handle for swimlane
1cb10a2 
This was in place in mxGraph and had been disabled for unknown reasons during the migration.
@tbouffard tbouffard added the bug Something isn't working label Dec 30, 2024
@coderabbitai
Copy link

coderabbitai bot commented Dec 30, 2024 •
edited
Loading

Walkthrough

The pull request introduces a modification in the VertexHandler class within the VertexHandler.ts file. The change involves adjusting the conditional logic for adding a label shape as a sizer handle, specifically by removing a negation operator when checking if a graph cell is a swimlane. This alteration potentially allows swimlane cells to have label handles, modifying the conditions for creating and adding label shapes to the sizers array.

Changes

File Change Summary
packages/core/src/view/handler/VertexHandler.ts Modified conditional logic for adding label shape sizer handle, removing negation when checking swimlane cells

Sequence Diagram

sequenceDiagram
    participant VH as VertexHandler
    participant Graph as Graph
    
    VH->>Graph: isSwimlane(cell)
    alt Is Not Swimlane
        VH->>VH: Add Label Shape as Sizer Handle
    else Is Swimlane
        VH->>VH: Add Label Shape as Sizer Handle (New Behavior)
    end
Loading

The sequence diagram illustrates the updated logic for determining when to add a label shape as a sizer handle, showing that swimlane cells can now potentially have label handles compared to the previous implementation.

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d452293 and 1cb10a2.

📒 Files selected for processing (1)
  • packages/core/src/view/handler/VertexHandler.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tbouffard tbouffard marked this pull request as ready for review December 31, 2024 08:47
@tbouffard tbouffard merged commit 89451a2 into main Dec 31, 2024
6 checks passed
@tbouffard tbouffard deleted the fix/VertexHandler_ignore_swimlane branch December 31, 2024 17:31
This was referenced Jan 13, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tbouffard