YAPSP: TableView/QAbstractTableModel based parameter list#12876
YAPSP: TableView/QAbstractTableModel based parameter list#12876DonLakeFlyer merged 1 commit intomasterfrom
Conversation
This was changed due to performance problems with the GridLayout based approach. TableView give us windowing over the rows so we don't instantiate them until needed.
|
I'm very late, but I finally had the time to test this, and it seems perfect. Thank you so much! Amazing job. I recorded a performance/feel comparison with one of our SkyDroid H16 because I think the performance was a lot worse than with your Herelink or Galaxy Tab: param-list-perf-comparison.mp4I was pretty sure the main issue was the regexp JIT stuff, so I included a build with just that fix in the comparison. But that clearly wasn't it, since it's only a tiny bit faster, if at all. The fixes in this PR make it work perfectly again (and IMO an explicit search button isn't needed with this kind of performance). I forgot to include a clip of stable as a baseline but for reference, it feels as good as with this fix. |
|
@rubenp02 Thanks so much for verifying. Bit of a wild ride in determining the real problem here :) |
Yes Another Parameter Search Pull. TableView/QAbstractItemModel basically achieves the best of both worlds with respect to ListView caching and only created visible items as well as more control over column visuals. This is fully implemented now.
Replacement for: #12869 and #12866