Fix super slow parameter search in low end devices#12869
Closed
rubenp02 wants to merge 1 commit intomavlink:masterfrom
Closed
Fix super slow parameter search in low end devices#12869rubenp02 wants to merge 1 commit intomavlink:masterfrom
rubenp02 wants to merge 1 commit intomavlink:masterfrom
Conversation
Updated the ParameterEditorController's _performSearch method to fix a misuse of QRegularExpression which led to a large regexp JIT overhead (source: https://forum.qt.io/topic/103687/qregularexpression-construction-time). The method has also been slightly refactored to improve indentation and remove an unused local variable.
Collaborator
|
Don't know if unit tests got hung up because of changes or just random. I'll try running them again |
Collaborator
|
Replaced... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix super slow parameter search in low end devices
Description
Updated the ParameterEditorController's _performSearch method to fix a misuse of QRegularExpression which led to a large regexp JIT overhead (source: https://forum.qt.io/topic/103687/qregularexpression-construction-time).
The method has also been slightly refactored to improve indentation and remove an unused local variable.
Checklist:
Related PR
#12866
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.