Skip to content

Add MAV_PARAM_ERROR TYPE_MISMATCH, TYPE_UNSUPPORTED, READ_FAIL#2358

Merged
hamishwillee merged 6 commits intomasterfrom
hamishwillee-param_error_type_mismatch
Oct 16, 2025
Merged

Add MAV_PARAM_ERROR TYPE_MISMATCH, TYPE_UNSUPPORTED, READ_FAIL#2358
hamishwillee merged 6 commits intomasterfrom
hamishwillee-param_error_type_mismatch

Conversation

@hamishwillee
Copy link
Copy Markdown
Contributor

This reflects an error path in PX4 - attempting to set a real param using an int type or visa versa.

@peterbarker @julianoes Make sense to you?

@hamishwillee
Copy link
Copy Markdown
Contributor Author

ALso, in PX4 I can differentiate two errors on a read - the parameter does not exist, or it can't be read - but we don't know why. it might be corrupt perhaps, or perhaps they type is wrong.

Is it reasonable to add a specific MAV_PARAM_ERROR_READ_ERROR and a general MAV_PARAM_ERROR_TYPE_UNKNOWN_ERROR ?

@peterbarker
Copy link
Copy Markdown
Contributor

ALso, in PX4 I can differentiate two errors on a read - the parameter does not exist, or it can't be read - but we don't know why. it might be corrupt perhaps, or perhaps they type is wrong.

Is it reasonable to add a specific MAV_PARAM_ERROR_READ_ERROR and a general MAV_PARAM_ERROR_TYPE_UNKNOWN_ERROR ?

Wouldn't that be MAV_PARAM_ERROR_TYPE_ERROR again?

If READ_ERROR is a thing on PX4 another entry seems warranted.

@hamishwillee
Copy link
Copy Markdown
Contributor Author

ALso, in PX4 I can differentiate two errors on a read - the parameter does not exist, or it can't be read - but we don't know why. it might be corrupt perhaps, or perhaps they type is wrong.
Is it reasonable to add a specific MAV_PARAM_ERROR_READ_ERROR and a general MAV_PARAM_ERROR_TYPE_UNKNOWN_ERROR ?

Wouldn't that be MAV_PARAM_ERROR_TYPE_ERROR again?

I guess it could be. Though why not MAV_PARAM_ERROR_TYPE_UNKNOWN?

If READ_ERROR is a thing on PX4 another entry seems warranted.

OK

I was also thinking perhaps

MAV_PARAM_ERROR_UNSUPPORTED_TYPE - to catch use of MAV_PARAM_TYPE_UINT8 say ?

@hamishwillee
Copy link
Copy Markdown
Contributor Author

OK, I think these are good now. @peterbarker Any issue before I squash merge?

@hamishwillee hamishwillee changed the title Add MAV_PARAM_ERROR_TYPE_MISMATCH entry Add MAV_PARAM_ERROR TYPE_MISMATCH, TYPE_UNSUPPORTED, READ_FAIL Oct 16, 2025
@hamishwillee hamishwillee merged commit 342530b into master Oct 16, 2025
19 checks passed
@hamishwillee hamishwillee deleted the hamishwillee-param_error_type_mismatch branch October 16, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants