Add MAV_PARAM_ERROR TYPE_MISMATCH, TYPE_UNSUPPORTED, READ_FAIL#2358
Add MAV_PARAM_ERROR TYPE_MISMATCH, TYPE_UNSUPPORTED, READ_FAIL#2358hamishwillee merged 6 commits intomasterfrom
Conversation
|
ALso, in PX4 I can differentiate two errors on a read - the parameter does not exist, or it can't be read - but we don't know why. it might be corrupt perhaps, or perhaps they type is wrong. Is it reasonable to add a specific MAV_PARAM_ERROR_READ_ERROR and a general MAV_PARAM_ERROR_TYPE_UNKNOWN_ERROR ? |
Wouldn't that be If READ_ERROR is a thing on PX4 another entry seems warranted. |
I guess it could be. Though why not
OK I was also thinking perhaps MAV_PARAM_ERROR_UNSUPPORTED_TYPE - to catch use of MAV_PARAM_TYPE_UINT8 say ? |
|
OK, I think these are good now. @peterbarker Any issue before I squash merge? |
This reflects an error path in PX4 - attempting to set a real param using an int type or visa versa.
@peterbarker @julianoes Make sense to you?