DOC: Add __all__ and document lock#31
Conversation
numpy/random/mt19937.pyx
Outdated
There was a problem hiding this comment.
It would be nice to refactor the BitGenerators to inherit from a common base class so all this does not need repeating
There was a problem hiding this comment.
I agree. I think the challenge here is the limitation imposed by Cython extension types since you can't do all of the Python doc string fixes after the fact. n times copy-pasta is a bit soul destroying
Would probably need to use composition instead of inheritance where a small extension class provides the core functionality to a larger Python class, which could then avoid repeats.
There was a problem hiding this comment.
never mind, this already appears as a follow-on task in numpy#13164
|
There do not seem to be examples of use of |
No, but I should include one in the cython example code. |
Add docstring for lock Use __all__ to discuorage unless attributes from appearing
Remove traces of the three removed bit generators Add lock to Cython examples
|
I updated the Cython example to use lock. I also found man remnants of the 3 removed generators, which were all removed. |
Merge in numpy-hpy from ss/array_array_full to labs-hpy-port * commit '0fa5e68fbdfede59074ff30dd867cb4e1113b753': Remove the use of typeobjects: global PyObject* array Fully port array_array (enough for the example)
Add docstring for lock
Use all to discuorage unless attributes from appearing